Repository navigation
Conversation
The title's backup card does not exist until 03.05's heal, which loads at 03.06's start; runs 12 (02.05) and 15 (03.01) opened it anyway and read no card. The first checkpoint a backup loads at is the first whose plan's start_signature names a card count (03.06). Before it, a failure after an autosave in the checkpoint's last step reloads that save and runs on from the next checkpoint; any other stops as no_backup_yet, saying where the latest save is. An unmatched start before it opens no card either.
# Conflicts: # SerialPrograms/Source/VideoGames/PokemonLZA/Programs/AutoStory/PokemonLZA_AutoStoryBackups_Tests.cpp
rewind_game() put its catch_in_zone stand-in in place of the handler with_autosave_sightings() had wrapped, so a badge the catch saw was never noted: 02.05's autosave in its last step went unseen and the run stopped with no rewind. The stand-in is now wrapped like the real one.
Owner
Author
|
Superseded by #644 (one lean branch; split for review later) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #632 (base plza/no-backup-before-pc; the diff shows only this change).
PLZA has no backup save until the first Pokemon Center save (03.05's heal, which loads at 03.06's start), but runs 12 (02.05) and 15 (03.01) on console B, 2026-11-16, opened the backup card anyway and read none. The first checkpoint a backup loads at now comes from the plans: the first whose start_signature names a backup card count ("registered"), which is 03.06. Before it, a failure after an in-checkpoint autosave opens no card: an autosave in the checkpoint's last step (the plan's autosave position) is the next checkpoint's start, so the run reloads it and goes on from there; anywhere else it stops as no_backup_yet with "no backup save exists before 03.06: the latest save is ". An unmatched start before 03.06 opens no card either.
Tested with new AutoStoryBackups "first backup" cases (02.05 autosaving mid-checkpoint and in its last step, 03.06 still rewinding) and a start case for 02.05. The rewind tests' badge look now comes 2 s after the first look: since #632, a badge in a checkpoint's first 1.5 s counts as the save before it.