Skip to content

PLZA scenes: golden key sequences for the scene steps - #635

Closed
dayfine wants to merge 2 commits into
plza/scene-advance-afrom
plza/screen-table
Closed

dayfine wants to merge 2 commits into
plza/scene-advance-afrom
plza/screen-table

Conversation

@dayfine

@dayfine dayfine commented Nov 17, 2026

Copy link
Copy Markdown
Owner

Depends on #634 (base plza/scene-advance-a; the diff shows only this change).

The PLZA scene steps each map screens to buttons their own way, and the recent failures (a B landing on Alton's opening choice, an A on a closing box restarting a talk) were all that mapping plus timing. This adds golden sequences: screens recorded from console B logs, played back by time through the built-in plan's step with its args, with every press checked against the key its screen calls for (A, B, Up, none) and the step's end. Cases: 03.11 leave_mable, 03.04 pokedex_app, 01.03 andi_battle_start, 02.05 and 03.01 floor_question, 01.02 pancham_cornered (French) and battle_area, 03.05 heal_party, and 03.01 lobby_scene up to Alton's choice with A on the text (#634). The 03.02b map talk has none: talk_through_map_screen logs only its presses, not what it saw. No behaviour change; Fork Draft CI runs the suite (console B was busy, so nothing was built locally).

The proposed shared table, with per-step overrides as data (not migrated yet):

screen key override (steps)
text (arrow or drawing) B text_key A: advance_with_a, story_battle_start, map talk before its card
choice A (Up first off the top row) end_on choice: text_to_choice
tutorial card A
menu, nothing reads none menu_key B every look (mash), every 2 s (pokedex), once per gap (gap_press)
map B
A prompt / party bar / hint none end_on held 1 s (prompt past min_length)
fade, quiet, battle HUD none end_on: Nth black fade settled, quiet_is_control, stop_at_battle

Console runs' screens played back by time through the built-in plan's
step, every press checked against the key its screen calls for: 03.11
leave_mable, 03.04 pokedex_app, 01.03 andi_battle_start, 02.05 and 03.01
floor_question, 01.02 pancham_cornered and battle_area, 03.05 heal_party,
and 03.01 lobby_scene up to Alton's choice. The header records the
screen -> key table with per-step overrides these share.
@dayfine

dayfine commented Nov 17, 2026

Copy link
Copy Markdown
Owner Author

Superseded by #644 (one lean branch; split for review later)

@dayfine dayfine closed this Nov 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant