Repository navigation
Conversation
Console runs' screens played back by time through the built-in plan's step, every press checked against the key its screen calls for: 03.11 leave_mable, 03.04 pokedex_app, 01.03 andi_battle_start, 02.05 and 03.01 floor_question, 01.02 pancham_cornered and battle_area, 03.05 heal_party, and 03.01 lobby_scene up to Alton's choice. The header records the screen -> key table with per-step overrides these share.
Owner
Author
|
Superseded by #644 (one lean branch; split for review later) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #634 (base
plza/scene-advance-a; the diff shows only this change).The PLZA scene steps each map screens to buttons their own way, and the recent failures (a B landing on Alton's opening choice, an A on a closing box restarting a talk) were all that mapping plus timing. This adds golden sequences: screens recorded from console B logs, played back by time through the built-in plan's step with its args, with every press checked against the key its screen calls for (A, B, Up, none) and the step's end. Cases: 03.11 leave_mable, 03.04 pokedex_app, 01.03 andi_battle_start, 02.05 and 03.01 floor_question, 01.02 pancham_cornered (French) and battle_area, 03.05 heal_party, and 03.01 lobby_scene up to Alton's choice with A on the text (#634). The 03.02b map talk has none: talk_through_map_screen logs only its presses, not what it saw. No behaviour change; Fork Draft CI runs the suite (console B was busy, so nothing was built locally).
The proposed shared table, with per-step overrides as data (not migrated yet):