Repository navigation
Conversation
walk_to_marker failed at the Research Lab's fence (console B, German, 2026-11-17 00:48-00:50: held up at 24, then at 10, sidesteps, then objective_not_reached). The user: "much easier based on my very original recorded path -- as long as we are facing the street -- using walk-to-marker is more likely to fail due to the fence". A walk gets the arg "heading": once the player has control it faces that minimap heading (face_heading()), then walks its legs. The no-console game takes an optional MinimapArrowReader for it; without one such a walk fails as console_only. The lint rejects "heading" beside "first_turn_when_chained". 03.09's to_research_lab: heading 264 (the arrow on the user's "faces street" frame read 263.7), straight 6.5 s, left into the gate, held until Ryon's dialog. To be verified on console.
The walk to the lab gate took a 272 reading for 264 (the old 10 degree tolerance) and ended right of the gate; the user put it about 15 degrees too far right.
A chained run that turned right 90 degrees first failed to reach Mable (console B 2026-11-17 01:25); the user judged the turn unneeded.
…-street # Conflicts: # SerialPrograms/Source/VideoGames/PokemonLZA/Programs/AutoStory/PokemonLZA_AutoStoryGame.cpp # SerialPrograms/Source/VideoGames/PokemonLZA/Programs/AutoStory/PokemonLZA_AutoStoryGame.h # SerialPrograms/Source/VideoGames/PokemonLZA/Programs/AutoStory/PokemonLZA_AutoStoryGame_Tests.cpp
Owner
Author
|
Superseded by #644 (one lean branch; split for review later) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #636 (base
plza/0311-facing; the diff shows only this change).03.09's walk_to_marker got stuck on the Research Lab's fence (console B, German, 2026-11-17: held up at 24 and 10, sidesteps, then objective_not_reached). The user: "much easier based on my very original recorded path -- as long as we are facing the street -- using walk-to-marker is more likely to fail due to the fence".
A
walknow takesheading: once the player has control it faces that minimap heading with face_heading(), then walks its legs. The no-console game takes an optional minimap arrow for it; without one, such a walk fails as console_only. 03.09's to_research_lab faces 264 (the minimap arrow on the user's "faces street" frame reads 263.7), walks 6.5 s down the street, then turns left into the gate and holds until Ryon's dialog. TO BE VERIFIED on console.The user asked to face the marker first and then turn by the difference between the two frames' headings. The arrow shows which way the player faces, not the camera, and reads 268.5 on the marker frame, so that frame does not give the marker's heading. This PR faces the street heading directly instead.
Tested: new lint cases and 03.09 run cases in the PLZA AutoStory story-game suite (face then legs, no arrow, heading missed); fork CI runs them.