Repository navigation
Conversation
A checkpoint's execution can carry {"verify": {"tries", "min_pass",
"reset_budget"}}. run_segment() then plays the row as a loop: phase 1's
tries from its start save save nothing and reload between them, and the
segment stops below min_pass; phase 2 reloads and tries again until a try
passes, which saves, or stops after reset_budget. A try passes when it
completes, the game's postcondition check holds and the game's new
verify_pass hook holds; a start check that fails stops the loop at once.
FRLG reads the block into its rows and passes them to the segment; its
verify_pass is the League's item caps, counted from the start save's
supplies (league_row_pass()). Engine tests run the loop on a fake game.
Owner
Author
|
Superseded by #652 (frlg/lean), which continues from this branch's tip; the branch stays. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #641 (base
frlg/e4-loop; the diff shows only this change).The League's verification loop moves into the shared story engine, as the user asked: a checkpoint's plan can carry
"execution": {"verify": {"tries": 10, "min_pass": 5, "reset_budget": 5}}, andrun_segment()plays that row as phase 1 (tries from one save, no save, stop below min_pass) then phase 2 (retry until a pass, which saves, within reset_budget). A try passes when it completes, the game's postcondition check holds and a newSegmentHooks::verify_passholds; a failing start check stops the loop. FRLG reads the block into its rows and supplies the pass predicate (the League's item caps, counted from the start save's supplies). Not yet in this PR: splitting 20.01 into five verify rows, removingrun_league_fight()/plan_league()/between_fight_action(), and a console top-up step. Tested with the newPokemon::StoryVerifyRowssuite (the loop on a fake game); touched files compiled locally.