Skip to content

Code health: lint the #648 review rules - #664

Merged
dayfine merged 1 commit into
agentsfrom
agents-lint-review-rules
Nov 19, 2026
Merged

dayfine merged 1 commit into
agentsfrom
agents-lint-review-rules

Conversation

@dayfine

@dayfine dayfine commented Nov 19, 2026

Copy link
Copy Markdown
Owner

Base: agents; no parent PRs; the diff shows only this change.

The new "Types, names and comments" rules from the #648 review were only enforced in review. This makes extern template a code-health error and adds four advisories (free_function, uncalled_method, one_user_alias, bool_with_failure) in devtools/code_health/review_rules.py, each with a bypass tag. I calibrated them on origin/main, autostory/shared-core (before and after its review), plza/lean and frlg/lean; the README records the hit counts and why all but extern template stay advisory. On shared-core before the review the diff run catches StoryEngine, registry(), run_checkpoint, EventLogger, CheckpointReport, StoryEngineReport and all five extern templates. Self-tests (unittest discover on devtools/code_health/tests) pass.

extern template is an error (extends the TotW #103 extern check). Four advisories in
review_rules.py: free_function, uncalled_method, one_user_alias, bool_with_failure.
README records hit counts on origin/main, shared-core, plza/lean and frlg/lean.
@dayfine
dayfine marked this pull request as ready for review November 19, 2026 05:10
@dayfine
dayfine merged commit 4935d77 into agents Nov 19, 2026
1 check passed
@dayfine
dayfine deleted the agents-lint-review-rules branch November 19, 2026 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant