Repository navigation
code_health: test-case check reads brace-initialized fields - #670
Merged
Merged
Conversation
The statement splitter cuts `std::string name = {};` at its `{`, so
structures() never saw the field and the test-case check failed every
case struct that follows the `= {}` rule for Windows clang.
dayfine
marked this pull request as ready for review
November 19, 2026 06:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test-case check failed any case struct whose fields were written
std::string name = {};orInput input{};, because the statement splitter cuts those at the{and the field reader only looked at;-ended statements. That forced #667 and #648 to leavename/input/expectationbare, against the Windows clang= {}rule. The field reader now also takes brace-initialized fields. Added a contract test (value-initialized case passes, a name in the input still fails); the code_health suite passes, and the ScreenEventsCase and RangeCase files pass with= {}added while a copy with a field removed still fails.