Skip to content

Merge lab/main into lab/tooling (Headless CC + PanelCatalog + StartupArguments) - #671

Merged
dayfine merged 82 commits into
lab/toolingfrom
lab/sync-main-to-tooling
Nov 19, 2026
Merged

dayfine merged 82 commits into
lab/toolingfrom
lab/sync-main-to-tooling

Conversation

@dayfine

@dayfine dayfine commented Nov 19, 2026

Copy link
Copy Markdown
Owner

Base: lab/tooling (782e70e63)
Merged: origin/lab/main (084ad8ca7)

Brings StartupArguments, LabStartupPolicy, PanelCatalog (#660), and HeadlessHost / --headless --run (#669) into lab/tooling alongside MgbaLink and PA_MGBA_LINK=1 (#650).

Conflict resolutions

  • Kept lab/tooling versions of Lab.md, LabChannel.*, LabRequest.*, and NintendoSwitch_LabCommands.* (newer user-hold, mcp-followups, and app-preflight work).
  • Kept lab/main's StartupArguments / HeadlessHost / SerialProgramsTests runner in Main.cpp, CommandLineTests.cpp, and ComputerPrograms_UnitTestRunner.h.
  • Kept both sides' add_tests_* registrations in ComputerPrograms_UnitTestRunner.cpp.

Testing

  • Local: CoreLib (-DPA_CORE_ONLY=ON) compiled cleanly; Draft CI will build SerialPrograms + SerialProgramsTests.

dayfine and others added 30 commits October 24, 2026 08:32
* Add reusable C++ code-health ratchet and agent verification command

* Refresh initial debt snapshot against current fork main

* Match native test working directory and platform profile support

* Align native test runtime resources with configured build directory

* Lint incremental C++ changes without baseline or stored fixtures
…am merge-base (#70)

* Code health: default the base to the merge-base with upstream

Comparing with a stale fork main reported upstream changes as the
branch's own. Without --base-ref, use git merge-base HEAD upstream/main
(origin/main when there is no upstream remote) and print the base used.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* Code health: check the shape of new and changed classes

Count public methods (limit 7, advisory above 5), public non-static data
in classes with mutating methods, and single-method interfaces, with a
lexical member scan over lizard's tokens. Classes are compared with the
base like functions, so only new violations and growth fail.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* Code health: keep game modules out of shared code

Fail when a change adds an #include of Pokemon/, PokemonBDSP/ or
VideoGames/ to Common, CommonFramework or CommonTools. config.py lists
game and platform top-level directories; a test keeps the list complete.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* Code health: quiet class checks on legacy classes and const fields

Runs over origin/main~20..main reported legacy classes far over the
public-method limit as advisory, and a public const type field as
mutable data. Advise only for 6-7 methods and exempt const fields.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…nal homes (#42)

* Design doc: shared AutoStory run flow, 2D movement, and an FRLG AutoStory

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* Design doc: lead with problem, situation and proposal; FireRed, solo from a new game

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* Design doc: full upstream reference for the SwSh draft

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* Design doc: prior art (junari's FRLG script) and ComputerControl#259

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* Design doc: PR plan with sizes for reviewers

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* Design doc: FRLG pilot to Brock first, shared code later

Reorder the plan so the first PRs touch only FRLG files and end in a runnable
pilot (new game -> Boulder Badge in about 10 PRs, first runnable at PR 5),
with an F3 go/no-go gate on checkpoints and Switch hours. The SV/BDSP shared
run flow moves to a later phase. Add a one-page upstream-facing proposal,
standalone review comment drafts for PokemonAutomation#1717
(not posted), and the FRLG authors on main. Drop the agent process section.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* Design doc: reusable pieces in their final homes, no copy-then-move

The plan wrote FRLG's run flow and tile path inside the FRLG module and moved
them out in phase D (R0, T4): move-only PRs of our own code. Adding new files
to a shared module changes no one else's code, so they now start in
Pokemon/AutoStory and Pokemon/Navigation. New section 0.1 lists the
game-neutral pieces from SV, BDSP PokemonAutomation#1717, SwSh PokemonAutomation#1207, BBQ and the BDSP lab
work (screen machine, step trace, failure policy, list selection, system
keyboard, Lab Console, run flow, tile path, decision tests) with their
homes; D4 builds the FRLG intro on the screen machine. The proposal says
the same.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* Design doc: what broke on the console and the rule each break taught

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* Design doc lessons: drop the Max Lair entry, it is not AutoStory

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* AutoStory design notes: screen machine, walking, map, planner, executor

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* AutoStory design: plan on routes, trust town grids only once verified

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* AutoStory docs: what broke in Butters' 00.04 and 00.05, and what replaced it

Lessons: a table of his recorded route against what console B showed
(timed legs, slot-3 Ember, no healing, pixel-matched Potion, the Poke
Mart lady and Barry missed by a tile), our own mistakes in this round
(an optional step kept for hours, claims not checked on screen, map
errors, untiled movement, a fixed OCR cut), and stepping through new
ground before automating it. Design: the executor, move choice,
training and Potion healing as built, and the Lab Console stepping.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* AutoStory lessons: link our commit for each fix; the Pokétch president's talk

Each row of the Butters comparison and each of our own mistakes now
links the fork commit that fixed it, on bdsp/new-game-intro-v2. Adds
what stepping through Phase 23 showed: A re-opens the president's talk,
B advances it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* AutoStory lessons: 00.05 stepped through to the PC; read positions from the ground; towns need grids too

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* AutoStory: segment 01 plan (story, trainers, maps, work order); segment 00 leftovers scheduled

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* AutoStory lessons: segment 01 runs r81 to r90, one rule per failure

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* AutoStory lessons §10: Oreburgh Mine, Roark's gym, Route 204 to Floaroma; Butters' segment 01

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* AutoStory: shared navigation core and the FRLG Brock / BDSP Floaroma MVP branches

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* AutoStory: end the FRLG run with Mew, through the Sevii Ruby and Sapphire

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* AutoStory navigation stack: fork PR numbers

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* AutoStory: queue the BDSP MVP follow-ups (clock pin, shared walker, resources)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* AutoStory lessons §11: Floaroma MVP runs r107 to r109 and the lab around them

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* AutoStory lessons: split into Part 1 for Butters (PokemonAutomation#1717) and Part 2 for us

Sections are renumbered; cross-references updated. Butters' segment 01
table and the two PokemonAutomation#1717 failures from r108 get their own sections in Part 1.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* AutoStory docs: mark the segment plans done or superseded, the PokemonAutomation#1717 drafts stale; pose status

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
With --github (passed by CI, default when GITHUB_ACTIONS=true), print each
failure as ::error and each advisory as ::warning at its file and line, capped
at 50 per level. Advisories now carry locations: changed files over 500 lines,
functions over 25 lines, classes with 6-7 public methods.


Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
When <user files>/LabControl/ exists, the main window polls it every
500 ms. A "start" or "stop" file does what clicking Start/Stop Program
does and is then deleted; "state" holds the program state and the
selected program's identifier. Nothing changes when the folder is absent.

The button's handler moves into start_or_stop_program() so both paths
share it.


Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
* Add Command File Runner, a developer program driven by text command files

Answering "does this detector fire on that screen?" meant a rebuild and a
full program run. Command File Runner runs .txt files dropped into
<folder>/inbox against the live console, one command per line (press,
dpad, stick, wait, shot/shots, detect, wait_for/expect, state, close_game,
help, stop), and writes a timed result file with screenshots to
<folder>/outbox, stopping a file at its first failing line.

Options set the command folder and whether to stop once the inbox is
empty. Games can register their own commands and detectors. README.md
next to the code documents the file format and every command; like the
other testing programs it has no page on the documentation site.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* Command File Runner: unit tests for reading command files

Moves the line splitting, button and D-pad names and the inbox order into
their own file, unchanged, and tests them without a console.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* Command File Runner: replace CommandLine with free functions

A command line is now just its words: split_command_line() returns them,
and required_arg(), optional_number() and optional_duration() read
arguments from them, with the same error messages. All definitions move
to the .cpp. Adds a unit test for the argument readers and checks the
error messages.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* Command File Runner: read numbers with strtod() instead of std::stod()

On the macOS Intel CI build, the std::invalid_argument from std::stod()
escapes the catch (std::exception&), so the "argument errors" test failed
with "Unknown exception". strtod() reports a bad number without
throwing; the error message is unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* Command File Runner: walk until the screen holds still, and report how long it moved

A timed stick hold moves a different number of tiles from one try to the
next, so a map measured with holds is not measured. "walk x y" holds the
left stick in 200 ms slices and stops when two slices in a row barely
change the screen (a wall, a sign, someone in the way).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* Command File Runner: 'history label' saves the console's recent video

With Stream History on, a lab script can keep the video of a program run
that just ended (the RNG reset and launch) by running this right after.
Ported from beceebc on lab/frlg-nav-cfr to the free-function command
signature.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…rface check (#82)

A class nested in another class, or in a detail or anonymous namespace, is an
implementation detail such as a type-erasure base, not an interface others
implement. MoveOnlyFunction's private Callable base was flagged.


Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* Code health: skip nested and detail classes in the single-method interface check

A class nested in another class, or in a detail or anonymous namespace, is an
implementation detail such as a type-erasure base, not an interface others
implement. MoveOnlyFunction's private Callable base was flagged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* Code health: lexical C++ style checks on added lines

Check the lines a change adds for the upstream bans (std::filesystem,
std::thread, std::mutex, std::async), control-flow brace formatting, and
the Abseil tips adopted in the fork's C++ style notes: mutable globals
(#103), new/delete (#126), std::bind (#108), return std::move(local)
(#120), top-level const by-value header parameters (#109), bool
parameters (#94), header using-directives (#153) and forward
declarations. A comment that describes a neighbouring function is an
advisory.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…95)

Changing a parameter's type (std::function to MoveOnlyFunction in #90) changed
the function's key, so an existing 133-line constructor was held to the new
limit of 50 instead of its base length. Functions now match on their qualified
name without parameters; messages still show the full signature.


Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
* Code health: skip nested and detail classes in the single-method interface check (#82)

A class nested in another class, or in a detail or anonymous namespace, is an
implementation detail such as a type-erasure base, not an interface others
implement. MoveOnlyFunction's private Callable base was flagged.


Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

* Code health: lexical C++ style checks on added lines (#94)

* Code health: skip nested and detail classes in the single-method interface check

A class nested in another class, or in a detail or anonymous namespace, is an
implementation detail such as a type-erasure base, not an interface others
implement. MoveOnlyFunction's private Callable base was flagged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* Code health: lexical C++ style checks on added lines

Check the lines a change adds for the upstream bans (std::filesystem,
std::thread, std::mutex, std::async), control-flow brace formatting, and
the Abseil tips adopted in the fork's C++ style notes: mutable globals
(#103), new/delete (#126), std::bind (#108), return std::move(local)
(#120), top-level const by-value header parameters (#109), bool
parameters (#94), header using-directives (#153) and forward
declarations. A comment that describes a neighbouring function is an
advisory.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

* code_health: match functions to their base by name, not by signature (#95)

Changing a parameter's type (std::function to MoveOnlyFunction in #90) changed
the function's key, so an existing 133-line constructor was held to the new
limit of 50 instead of its base length. Functions now match on their qualified
name without parameters; messages still show the full signature.


Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

* Settings: default audio display and collapsed console settings

Two global settings for people who run many programs on one lab machine:
"Default Audio Display" (Audio Pipeline group) is what a program's console
shows for its audio until that console's own setting is saved, so a new
panel no longer opens with the frequency bars; and "Start with console
settings collapsed" folds each program's "Console N Settings" box at
creation, so the video is at the top. Both default to today's behavior.

AudioOption takes its initial display type from the global setting
instead of a fixed FREQ_BARS; a panel's saved value still wins.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
(cherry picked from commit 92d1ed3c6f6fa0468827ab15c51ec3cc71f01d32)

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…them on the DP images (#83)

* devtools/maps: level-aware map parser for AutoStory routes, with Veilstone examples

Flood-fills walkable pixels into levels, joins them only through stairs,
then plans over 16 px tiles that take a level. Judging tiles by colour
alone had routes climbing rock rims.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* devtools/maps: Oreburgh City and Mine B2F; squashed images, objects on the floor, console edits

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* devtools/maps: draw a data file's grid and a run's logged routes over its map; a sandtown profile

A grid off by a row or column plans legs to walls that aren't there
(Route 201 near Sandgem, r130a). python3 -m devtools.maps fetches a
Bulbapedia map by its archive hash path, reads a data file's grid rows,
named tiles and image origin, and draws them over the image as SVG with
the walks a console run planned and walked from SerialPrograms.log,
marking legs planned to a wall that did not stop as blocked. levels.py
gets a sandtown profile for towns on dirt and sand; README notes what it
gets right and wrong on Sandgem against the console-checked grid.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* devtools/maps: how to get a route working on the console, in three layers

Map, route and walk fail differently and are fixed in different places;
the README now says how to tell which failed, how to measure a map with
the Command File Runner's walk, and how to plan routes that end on walls.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* devtools/maps: levels.py marks tall grass

The tufts' greens on the DP route maps (measured on Route 204) are
walkable and a tile mostly made of them is written as '"' in the grid,
so a route sees where wild encounters are. Before, one of those greens
read as blocked and the tufts' outlines were taken for objects on the
floor, which blocked the whole grass block.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* devtools/maps: decode map grids from the pret decompilation

Grids traced from Bulbapedia's DP images have 12 px rows for 16 px
columns and cliffs painted taller than their tiles, so no offset fixes
them; the Platinum decompilation's collision matched the console at
every probed anchor (BDSP AutoStory run 1, 2026-10-31).

`decomp` fetches a map's land data, matrix and events from
pret/pokeplatinum or pret/pokediamond with gh api, caches them, and
prints the data files' C++ rows with the objects placed and a header
comment in the Data/MAPS.md form, or the bare rows. `overlay` takes
12 px rows, per-cliff row offsets and a text grid as its source. The
README leads with decomp first and keeps levels.py for maps no decomp
covers. Tests decode a synthetic map from Platinum-style and
Diamond-style trees.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* devtools/maps: drop the levels.py route pictures

The five PNGs under examples/ were routes levels.py read off Bulbapedia's
DP images (Veilstone's levels and two Gym routes, Oreburgh's Center to
the mine, Mine B2F to Roark): traced grids with the 3/4-row drift on
maps the decomp covers, and the README names none of them. The text
grids stay, marked as pre-decomp.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
…104)

* Code health: skip nested and detail classes in the single-method interface check (#82)

A class nested in another class, or in a detail or anonymous namespace, is an
implementation detail such as a type-erasure base, not an interface others
implement. MoveOnlyFunction's private Callable base was flagged.

Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E



* Code health: lexical C++ style checks on added lines (#94)

* Code health: skip nested and detail classes in the single-method interface check

A class nested in another class, or in a detail or anonymous namespace, is an
implementation detail such as a type-erasure base, not an interface others
implement. MoveOnlyFunction's private Callable base was flagged.


Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* Code health: lexical C++ style checks on added lines

Check the lines a change adds for the upstream bans (std::filesystem,
std::thread, std::mutex, std::async), control-flow brace formatting, and
the Abseil tips adopted in the fork's C++ style notes: mutable globals
(#103), new/delete (#126), std::bind (#108), return std::move(local)
(#120), top-level const by-value header parameters (#109), bool
parameters (#94), header using-directives (#153) and forward
declarations. A comment that describes a neighbouring function is an
advisory.


Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

---------



* code_health: match functions to their base by name, not by signature (#95)

Changing a parameter's type (std::function to MoveOnlyFunction in #90) changed
the function's key, so an existing 133-line constructor was held to the new
limit of 50 instead of its base length. Functions now match on their qualified
name without parameters; messages still show the full signature.

Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E



* Settings: default audio display and collapsed console settings

Two global settings for people who run many programs on one lab machine:
"Default Audio Display" (Audio Pipeline group) is what a program's console
shows for its audio until that console's own setting is saved, so a new
panel no longer opens with the frequency bars; and "Start with console
settings collapsed" folds each program's "Console N Settings" box at
creation, so the video is at the top. Both default to today's behavior.

AudioOption takes its initial display type from the global setting
instead of a fixed FREQ_BARS; a panel's saved value still wins.


Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
(cherry picked from commit 92d1ed3c6f6fa0468827ab15c51ec3cc71f01d32)

---------


(cherry picked from commit 0e737fb)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
* Design doc: shared AutoStory run flow, 2D movement, and an FRLG AutoStory

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* Design doc: lead with problem, situation and proposal; FireRed, solo from a new game

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* Design doc: full upstream reference for the SwSh draft

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* Design doc: prior art (junari's FRLG script) and ComputerControl#259

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* Design doc: PR plan with sizes for reviewers

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* Design doc: FRLG pilot to Brock first, shared code later

Reorder the plan so the first PRs touch only FRLG files and end in a runnable
pilot (new game -> Boulder Badge in about 10 PRs, first runnable at PR 5),
with an F3 go/no-go gate on checkpoints and Switch hours. The SV/BDSP shared
run flow moves to a later phase. Add a one-page upstream-facing proposal,
standalone review comment drafts for PokemonAutomation#1717
(not posted), and the FRLG authors on main. Drop the agent process section.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* Design doc: reusable pieces in their final homes, no copy-then-move

The plan wrote FRLG's run flow and tile path inside the FRLG module and moved
them out in phase D (R0, T4): move-only PRs of our own code. Adding new files
to a shared module changes no one else's code, so they now start in
Pokemon/AutoStory and Pokemon/Navigation. New section 0.1 lists the
game-neutral pieces from SV, BDSP PokemonAutomation#1717, SwSh PokemonAutomation#1207, BBQ and the BDSP lab
work (screen machine, step trace, failure policy, list selection, system
keyboard, Lab Console, run flow, tile path, decision tests) with their
homes; D4 builds the FRLG intro on the screen machine. The proposal says
the same.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* Design doc: what broke on the console and the rule each break taught

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* Design doc lessons: drop the Max Lair entry, it is not AutoStory

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* AutoStory design notes: screen machine, walking, map, planner, executor

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* AutoStory design: plan on routes, trust town grids only once verified

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* AutoStory docs: what broke in Butters' 00.04 and 00.05, and what replaced it

Lessons: a table of his recorded route against what console B showed
(timed legs, slot-3 Ember, no healing, pixel-matched Potion, the Poke
Mart lady and Barry missed by a tile), our own mistakes in this round
(an optional step kept for hours, claims not checked on screen, map
errors, untiled movement, a fixed OCR cut), and stepping through new
ground before automating it. Design: the executor, move choice,
training and Potion healing as built, and the Lab Console stepping.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* AutoStory lessons: link our commit for each fix; the Pokétch president's talk

Each row of the Butters comparison and each of our own mistakes now
links the fork commit that fixed it, on bdsp/new-game-intro-v2. Adds
what stepping through Phase 23 showed: A re-opens the president's talk,
B advances it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* AutoStory lessons: 00.05 stepped through to the PC; read positions from the ground; towns need grids too

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* AutoStory: segment 01 plan (story, trainers, maps, work order); segment 00 leftovers scheduled

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* AutoStory lessons: segment 01 runs r81 to r90, one rule per failure

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* AutoStory lessons §10: Oreburgh Mine, Roark's gym, Route 204 to Floaroma; Butters' segment 01

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* AutoStory: shared navigation core and the FRLG Brock / BDSP Floaroma MVP branches

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* AutoStory: end the FRLG run with Mew, through the Sevii Ruby and Sapphire

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* AutoStory navigation stack: fork PR numbers

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* AutoStory: queue the BDSP MVP follow-ups (clock pin, shared walker, resources)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* AutoStory lessons §11: Floaroma MVP runs r107 to r109 and the lab around them

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* AutoStory lessons: split into Part 1 for Butters (PokemonAutomation#1717) and Part 2 for us

Sections are renumbered; cross-references updated. Butters' segment 01
table and the two PokemonAutomation#1717 failures from r108 get their own sections in Part 1.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* AutoStory docs: mark the segment plans done or superseded, the PokemonAutomation#1717 drafts stale; pose status

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* Design: AutoStory lessons from 01.03/01.04 (D-pad tiles, clip then offset) and the MVP plan

Section 14 of the lessons: measured movement (D-pad taps are whole tiles,
stick holds drift), the clip-to-wall then D-pad offset route model, what
the screen tells, and the process mistakes. AutoStory-MVP-Plan.md: run 1
stays on fork #68; the compact series stacked on #66 follows it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* Design: AutoStory lessons 15 (Route 204, maps from the decomp) and the plan's next version

Lessons from 01.06 to 01.10 (r216 to r246): Bulbapedia DP images have 12 px
rows and cliffs painted taller than their tiles; the Platinum decomp gives
the real tiles and NPCs; a wandering NPC is not a wall; the planner's
cheapest legs are not a human's line; time-counted legs break when blocked;
a tap's screen change separates steps (21 to 50) from bumps (4 to 13); a
stale build ran twice. The MVP plan gets a "Maps from the game's data" track
(decoder, re-derivation, annotation, probes, PokemonNavigation) and the
planner/walker goals for the next version.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* Design: take in the decomp review and the route-impact check

The review's points on events, scripts, interaction identities and warps
go into the plan; the critique: terrain first, pokediamond before
pokeplatinum (DP's own map and event data exist), the walker's observation
is a separate problem, and the start is the maps 01.06 to 01.10 walk on.
The offline route-impact check: wall legs absorb the row differences, two
open legs and all of Jubilife's walks change, and the short grids pass
because vertical timing compensates by the same 4/3.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* Design: PR chain review, what moves to the core, what stays per game, FRLG and PokemonNavigation

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* Design: a 160 ms D-pad tap turns and steps (r248a)

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* AutoStory lessons: Route 204 after r246 (turn taps, bumps, until-stopped, banner end, routes as data, Diamond decomp)

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* Design: AutoStory architecture after the FRLG proof of concept

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* Architecture: the game simulator (encounters, Repel, battles, EXP, whiteout), parallel to the MVP

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* Architecture: SwSh/LA, story engine under Pokemon/AutoStory, reuse of RNG and Elite Four programs, milestones after the MVPs

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* Architecture: room for error - bounded safe inputs, then confirm the end state

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* Architecture: fold in the event model (#78) and the FRLG demo plan (#56)

Section 8 keeps the step rules from the event model (anchors, talks,
dialogs that end on a screen, named recoveries, resume as a re-check)
and the RNG hand-off rules from the demo plan. Section 5 gets the
movement table and the SwSh target; section 7 the planner's missing
search limits; section 6c links the FRLG events after Brock (#130).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* Architecture: generated maps ship in Resources (Packages), test maps stay compiled in

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ture doc (#153)

* Design: the AutoStory demo plan and FRLG sizing, next to the architecture

Copied from the notes branch (autostory/DEMO_PLAN.md, autostory/FRLG_SIZING.md,
as of 2026-11-01) so they live with AutoStory-Architecture.md, which now
links them here.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* Design: re-measure the AutoStory sizing; split per section, six upstream trees

Re-measured every fork PR at 17:30 (added lines, parent...child). Each
section now lists the upstream PRs it becomes, a summary up top gives
totals per track, and the single upstream chain is redrawn as six trees
with a two-slot queue across them.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* Design: sizing without BDSP; count the maps the story after Brock needs

BDSP and ScreenMachine (used only by BDSP) leave this doc; one line says
BDSP is tracked separately. The story from Pewter to the Hall of Fame
needs about 120 more FRLG maps (~0.4 MB of JSON), counted from #130's
outline against pokefirered's data/maps; they go to Resources in
Packages. Track D and tree 2 carry that work; totals recomputed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* Sizing: tracks lettered A–F in the summary's order

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
dayfine and others added 24 commits November 6, 2026 14:42
* Lab: seed isolated profiles and validate staged app identity

* Lab: seed settings under the runtime UserSettings path

* Lab: enforce profile and device leases before hardware opens

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Conflicts: CMakeLists.txt keeps both the lab device-access test runner and
upstream's Python bindings block; Main.cpp drops use_qt_ui() as upstream
PokemonAutomation#1856 removed it and all its callers, keeping lab's namespace layout.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
…reads) (#256)

* Lab channel: start the console's inference threads for each command

Game commands that watch the screen with run_until (frlg_route's walker)
crashed the app on a null inference pivot: a program's environment starts
those threads, the lab console did not.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* Lab channel: popups lists the app's message boxes, popups close presses their default button

A failed program leaves a modal Error box that nothing at the keyboard
closes on a lab console.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* Lab channel: popups compiles (QPushButton include)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

* Lab: start waits for the controller; state shows controller=

After a program switch the app reconnects the controller, which can stall.
A start in that window ran the program, which then failed with
"Incompatible Controller ... Actual: (none)". The state file now has
controller=ready|none from the panel's ControllerSession, and start waits up
to SECONDS (default 30) for it, refusing with "controller not connected".
labctl.sh passes a wait shorter than its own request timeout.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
lab-B refused its audio input every 5 s with "Device is not allowlisted",
which didn't say which device. The allowlist was right: the BDSP AutoStory
panel (and a few others) selected console A's capture audio
(...USB Video:1112100:3), and both cards are listed as "USB Digital Audio".
The refusal now names the kind and ID, decoding hex capture IDs.


Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Takes --list from the runner; keeps lab/main's CMake options and the
structured bindings in unit_test_names(); drops the runner's use_qt_ui()
stub, since lab/main has no use_qt_ui().

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
docs: design headless mode for SerialPrograms (--headless)
make_all_panel_lists() and find_panel(lists, id) replace PanelCatalog;
ProgramSelect keeps its lists, category map and add(). Drop the
unreachable null branch in load_panel_session() (holder now last) and the
JsonValue forward declaration. Tests: lookup past a divider and declined
intent skips load.
PanelCatalog: extract widget-free catalog and load_panel_session() (PR 1)
…lessProgramObserver

ProgramSession::Listener declares six pure virtuals; the observer overrode
only four, so Windows Clang rejected it as an abstract final class.
HeadlessHost: add --headless --run one-shot runner (PR 2)
…tooling

# Conflicts:
#	SerialPrograms/Source/CommonFramework/Main.cpp
#	SerialPrograms/Source/CommonFramework/Windows/Lab.md
#	SerialPrograms/Source/CommonFramework/Windows/LabChannel.cpp
#	SerialPrograms/Source/CommonFramework/Windows/LabChannel.h
#	SerialPrograms/Source/CommonFramework/Windows/LabChannel_Tests.cpp
#	SerialPrograms/Source/CommonFramework/Windows/LabRequest.cpp
#	SerialPrograms/Source/CommonFramework/Windows/LabRequest.h
#	SerialPrograms/Source/ComputerPrograms/ComputerPrograms_UnitTestRunner.cpp
#	SerialPrograms/Source/ComputerPrograms/ComputerPrograms_UnitTestRunner.h
#	SerialPrograms/Source/NintendoSwitch/Programs/CommandFileRunner/NintendoSwitch_LabCommands.cpp
#	SerialPrograms/Source/NintendoSwitch/Programs/CommandFileRunner/NintendoSwitch_LabCommands.h
#	SerialPrograms/Source/Tests/CommandLineTests.cpp
@dayfine
dayfine marked this pull request as ready for review November 19, 2026 08:01
@dayfine
dayfine merged commit e6c63e6 into lab/tooling Nov 19, 2026
7 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant