Repository navigation
Conversation
The station platform is read by its controls hint, text by the advance arrow alone. The reload's platform start check is gone; the party bar must hold 2 s with nothing busy to count as control.
…ach step A SignalProbe notes when each screen signal (party bar, controls hint, A prompt, advance arrow, shadow dialog box, autosave, banner, choice, fade) first showed over a wait. Scene end, each text press, check_can_walk, press_b_out_of_menu, set_text_speed_fast's exit and wait_for_platform log one "[Signals]" line with the deciding signal, every signal's first time, the last busy look and whether the old white-box detector still saw a box. The console backend runs that box detector again for the log only (shadow.dialog_box); no decision reads it. The platform detector is not restored: the controls hint already decides 01.01's platform.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base:
plza/lean(branched at dff6458). Diff shows only this change. Experiment: a console run decides whether it lands.PLZA AutoStory no longer runs the station platform detector or the white dialog box detector. 01.01's platform is read by its controls hint, and text by the advance arrow alone. Compiled the touched files locally; Fork Draft CI runs the unit tests.
wait_for_platform/opening_to_platform: end on the controls hint held 2 looks (after the autosave badge for the opening). Plus stops once the badge or the hint shows. Action names are unchanged.set_text_speed_fastend: party bar or controls hint. The platform reading is gone.text_shows): the advance arrow only. A choice box still classifies as the dialog screen and counts as busy, so choices are still answered without a box.default_text_button: B where the party bar shows, A otherwise. The old rule pressed B on every white box in a config where the party bar is control, which in practice meant overworld talks. Without the box, the party bar is the closest sign of an overworld talk. Presses now land only on the arrow, so A on a closing box (03.05's nurse) cannot happen from a look with no arrow.press_b_out_of_menu, marker walk B, StartScreenReader: the arrow replaces the box, or the box term is dropped (start reader)."end": "dialog"(03.09, 03.11): now"scene", which ends after 2 looks of the arrow or a fade.PlzaScreenObserverhas no dialog member. INTERACT_PROMPT and PLAYER_CAN_MOVE are no longer masked by the box.PlatformArrivalDetector, its files andplza-platform.jsonare deleted.Tests: the Game, chain, load, menu save, lines, detector and screen event suites now feed the arrow and the hint. Removed: load and chain cases that only tested the platform start check, and 20 scene golden cases. Those were recorded with the box detector masking the party bar, so the new observer's screens cannot be derived from them. They need re-recording from the console run.
Too risky to drop, kept:
StoryDialogDetectorstays inActions/PokemonLZA_AutoStoryBattles.cpp(any_dialog, the battle code), and its own detector tests stay.check_can_walkstill takes 2 looks of party bar with nothing busy (about 0.5 s). Right after a talk it could take a typing line as control. Its callers come after the scene machine has seen control.Now unused, not removed:
ScreenEvent::DIALOG_BOX(shared enum, out of scope) andWhiteDialogPart::BOX_ONLYmode (no PLZA caller left). Behavior to watch on console: whether the A prompt detector fires on text frames now that the box doesn't mask it (the Ryon 03.09 frame test checks one frame), and the save's "progress saved" text showing an arrow.