Skip to content

PLZA AutoStory: drop the platform and dialog box detectors (experiment) - #679

Draft
dayfine wants to merge 4 commits into
plza/leanfrom
plza/drop-detectors
Draft

dayfine wants to merge 4 commits into
plza/leanfrom
plza/drop-detectors

Conversation

@dayfine

@dayfine dayfine commented Nov 19, 2026

Copy link
Copy Markdown
Owner

Base: plza/lean (branched at dff6458). Diff shows only this change. Experiment: a console run decides whether it lands.

PLZA AutoStory no longer runs the station platform detector or the white dialog box detector. 01.01's platform is read by its controls hint, and text by the advance arrow alone. Compiled the touched files locally; Fork Draft CI runs the unit tests.

  • Platform start check after a reload ("older_save", and the chain's reload on it): dropped. A reloaded checkpoint's start stays UNCHECKED unless its first step checks it.
  • wait_for_platform / opening_to_platform: end on the controls hint held 2 looks (after the autosave badge for the opening). Plus stops once the badge or the hint shows. Action names are unchanged.
  • Walk control sign, set_text_speed_fast end: party bar or controls hint. The platform reading is gone.
  • ReloadProbe: minimap scores only.
  • Text (text_shows): the advance arrow only. A choice box still classifies as the dialog screen and counts as busy, so choices are still answered without a box.
  • Party bar as control: the party bar plus nothing busy (no arrow, fade or choice), held 2 s instead of 1 s. Without the box, the party bar now shows under a line while it types. A line types in under 1 s at fast speed, so 2 s doubles that margin and costs about 1 s at each scene end. The hint, A prompt and banner holds use "no arrow" where they used "no box".
  • default_text_button: B where the party bar shows, A otherwise. The old rule pressed B on every white box in a config where the party bar is control, which in practice meant overworld talks. Without the box, the party bar is the closest sign of an overworld talk. Presses now land only on the arrow, so A on a closing box (03.05's nurse) cannot happen from a look with no arrow.
  • Menu save text, press_b_out_of_menu, marker walk B, StartScreenReader: the arrow replaces the box, or the box term is dropped (start reader).
  • Walk "end": "dialog" (03.09, 03.11): now "scene", which ends after 2 looks of the arrow or a fade.
  • Producer: PlzaScreenObserver has no dialog member. INTERACT_PROMPT and PLAYER_CAN_MOVE are no longer masked by the box. PlatformArrivalDetector, its files and plza-platform.json are deleted.

Tests: the Game, chain, load, menu save, lines, detector and screen event suites now feed the arrow and the hint. Removed: load and chain cases that only tested the platform start check, and 20 scene golden cases. Those were recorded with the box detector masking the party bar, so the new observer's screens cannot be derived from them. They need re-recording from the console run.

Too risky to drop, kept:

  • StoryDialogDetector stays in Actions/PokemonLZA_AutoStoryBattles.cpp (any_dialog, the battle code), and its own detector tests stay.
  • check_can_walk still takes 2 looks of party bar with nothing busy (about 0.5 s). Right after a talk it could take a typing line as control. Its callers come after the scene machine has seen control.

Now unused, not removed: ScreenEvent::DIALOG_BOX (shared enum, out of scope) and WhiteDialogPart::BOX_ONLY mode (no PLZA caller left). Behavior to watch on console: whether the A prompt detector fires on text frames now that the box doesn't mask it (the Ryon 03.09 frame test checks one frame), and the save's "progress saved" text showing an arrow.

The station platform is read by its controls hint, text by the advance
arrow alone. The reload's platform start check is gone; the party bar
must hold 2 s with nothing busy to count as control.
…ach step

A SignalProbe notes when each screen signal (party bar, controls hint,
A prompt, advance arrow, shadow dialog box, autosave, banner, choice,
fade) first showed over a wait. Scene end, each text press, check_can_walk,
press_b_out_of_menu, set_text_speed_fast's exit and wait_for_platform log
one "[Signals]" line with the deciding signal, every signal's first time,
the last busy look and whether the old white-box detector still saw a box.
The console backend runs that box detector again for the log only
(shadow.dialog_box); no decision reads it. The platform detector is not
restored: the controls hint already decides 01.01's platform.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant