Repository navigation
mpc106: remove duplicated properties - #250
Merged
Merged
Conversation
`pci_J12` causes a duplicated property warning, and makes the `AtiMach64Gx` default value from machineyosemite.cpp not work. Since it's a Yosemite-only slot, it seems reasonable for only the machine to define. Also removes the similarly duplicted `pci_GPU` property, which had already been commented out in 40c8278.
mihaip
added a commit
to mihaip/infinite-mac
that referenced
this pull request
Nov 11, 2026
Picks up dingusdev/dingusppc#250 which fixes GPU initialization on the Blue & White G3. Also switches the default test OS for that machine to Mac OS 8.6, which is one of the earlier that it should be able to run. It still does not get past the early boot stage because DMA is not implemented on the DingusPPC side. To make that error less cryptic (the error text is just `null function`), make sure that we log the raw error on the worker side. That shows that it comes from the one-shot timer registered in `IdeChannel::assert_dmareq` because `this->channel_obj` is not initialized by CMD646.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pci_J12causes a duplicated property warning, and makes theAtiMach64Gxdefault value from machineyosemite.cpp not work. Since it's a Yosemite-only slot, it seems reasonable for only the machine to define.Also removes the similarly duplicted
pci_GPUproperty, which had already been commented out in 40c8278.