Repository navigation
fix: anchor RegExp hostname containing alternation - #95
Open
RaphaelFakhri wants to merge 1 commit into
Open
RaphaelFakhri wants to merge 1 commit into
RaphaelFakhri wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A RegExp
hostnamewith a top-level alternation is only partly anchored.hostregexpprepends^and appends$to the source, so/tobi\.com|loki\.com/becomes/^tobi\.com|loki\.com$/i, and hostnames such astobi.com.ferret.netandferret.loki.commatch. The README says a RegExp is "forced to match based on the start and end of the hostname".This change wraps the source in a non-capturing group,
^(?:source)$, for both string and RegExp hostnames. This makes theEND_ANCHORED_REGEXPcheck unnecessary, so the change removes it. Capture group numbering andreq.vhostare unchanged, and RegExps that are already anchored behave the same.Tests
should match any alternative:loki.comstill matches/tobi\.com|loki\.com/.should match entire hostname with alternation:tobi.com.ferret.netandferret.loki.comreturn 404. This test fails onmaster(expected 404, got 200) and passes with the fix.npm run lintandnpm testpass, andindex.jscoverage stays at 100%.Fixes #94