Repository navigation
Move minimatch past its advisory - #60
Merged
Merged
Conversation
npm audit fails hosted CI on GHSA-g3hv-75wg-m249, in minimatch before 11.0.1, which reaches us only through eslint, a development dependency, so nothing published changes. The latest eslint still requires minimatch 10, which has no patched release, so this overrides it. Remove the override once eslint and @eslint/config-array accept minimatch 11, which eslint/eslint#21463 tracks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm auditnow fails hosted CI on GHSA-g3hv-75wg-m249, a moderate advisory inminimatchbefore 11.0.1, so it blocks every pull request here. It reaches us only througheslint, a development dependency, so nothing published changes, andnpm audit --omit=devwas already clean.ESLint's latest release still requires
minimatch ^10.2.6, and the 10 line has no patched release, so this overridesminimatchto^11.0.5. npm's own suggestion was to moveeslintback to 9, which is a larger change. Remove the override onceeslintand@eslint/config-arrayacceptminimatch11, which eslint/eslint#21463 tracks.minimatch11.0.5 adds one package to the lockfile,@isaacs/nonrecursive-glob-match, from the same maintainer.Docs: none, because this changes one development dependency's version.
Validation
npm audit: found 0 vulnerabilities.npm run check: passes. ESLint also still reports a plantedno-unused-varserror under the override.