Repository navigation
Remove unused toml dependency; prepare 6.0.1 - #257
Merged
Merged
Conversation
serious_python declared toml ^0.15.0 but never imported it. toml 0.15 pins petitparser ^6, so apps that also depend on packages needing petitparser ^7 - such as file_picker 13 via file_picker_linux -> dbus -> xml - failed version solving. Drop the dependency and bump all packages to 6.0.1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
serious_python declared
toml: ^0.15.0but never imported it.toml0.15 pinspetitparser^6, so any app that also depends on a package needingpetitparser^7 fails version solving. For example,file_picker13 pulls infile_picker_linux2 →dbus→xml→petitparser^7. This breaksflet buildwith Flet's file_picker 13 upgrade (flet-dev/flet branchfeature/file-picker-13).Changes:
tomlfromserious_python's dependencies..fvmrc). The only changes are the removal oftoml/petitparserand the version bumps.Checked:
dart analyze bin libpasses, anddart run serious_python:main package --helpruns.