Repository navigation
fix(openapi): remove obsolete Ledger schema and info assertions - #2018
Merged
Merged
Conversation
Dav-14
marked this pull request as ready for review
November 6, 2026 11:46
NumaryBot
approved these changes
Nov 6, 2026
NumaryBot
left a comment
There was a problem hiding this comment.
The required automated review completed with no remaining findings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove two Ledger-specific validation blocks from Stack composition:
Ledger #2501 corrected the query-template contract: V2QueryParams is a flat object, so the old assertion fails with
Cannot iterate over null. The info assertions couple Stack validation to exact Ledger operation IDs, tags and response model names. Keep the composition behavior that preserves both info operations; only their assertions are removed.Other existing checks, including Ledger V2/V3 endpoint presence and Auth cleanup, remain unchanged. No overlays, component versions, generation configuration or HTTP contracts change.
Evidence
ledger_V2QueryParams.oneOf[].nix develop --no-write-lock-file --command just validate-openapipasses against the freshly composed document used to qualify fctl feat: Numscript: allow 0 and 100 inclusive in portions: Update doc #204.nix develop --no-write-lock-file --command just pre-commitpasses: fresh downloads, OpenAPI composition/validation and event generation. Registry output was temporarily disabled locally; the committed workflow is unchanged.git diff --checkpasses.Author analytical review: Principal Engineer PASS (no composition transformations changed); Product Engineer PASS (both info contracts preserved and fctl regression coverage passed); SRE PASS locally (full pre-commit passes). Remote release is not rerun or qualified.
Merge Danger
Door: two-way
Blast Radius: validation
Stack no longer checks the old query-param structure or exact Ledger info models/namespace-fragment allowlist. Composition and generated API behavior are unchanged. No merge, release or deployment is performed.