Repository navigation
fix(dedupe): Mark active session as crashed when deduplicating unhandled exceptions - #8109
Open
ryder777777 wants to merge 1 commit into
Open
ryder777777 wants to merge 1 commit into
ryder777777 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When an exception is logged (
logging.exception(...)) or captured as handled (capture_exception(...)) and then re-raised to crash the request/application (handled=False), the first capture updates the active session toerrored(errors=1,status="ok") and records the exception inDedupeIntegration._last_seen.When the re-raised unhandled exception subsequently reaches the framework or
excepthookcrash handler (mechanism={"handled": False}),DedupeIntegrationdrops the duplicate event beforeClient.capture_eventcalls_update_session_from_event, leaving the session inerroredstatus instead ofcrashed.This updates
DedupeIntegrationso that when it drops a duplicate event whose exception mechanism hashandled=False, it transitions any active session on the isolation/current scope tostatus="crashed".Issues