Repository navigation
fix: keep bind subscription cleanup idempotent - #363
Merged
liuliu-dev merged 1 commit intoOct 19, 2026
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The focused guard fixes stale-subscription cleanup, and regression tests cover both reported failure modes.
No open issues 🎉
What changed in this PR
Makes binding-subscription cleanup idempotent so repeated cleanup cannot invalidate a newer subscription.
Changes:
- Returns early when a subscription is already closed.
- Adds regressions for cached subscription reuse and stopping action binding after cleanup.
| File | Description |
|---|---|
| test/bind.ts | Tests subscription reuse and observer cleanup. |
| src/bind.ts | Guards against repeated unsubscription. |
Review effort: Max
liuliu-dev
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling an old
listenForBind(root)subscription'sunsubscribe()again after subscribing to the same root removes the new subscription from the cache. Another call then creates a second observer; closing the returned subscription can leave the original observer binding new actions.Return early when the subscription is already closed, so cleanup stays idempotent. Added tests for reusing the current subscription and for stopping action binding after cleanup.
Validation: both regressions failed before the fix; all 131 Chromium tests pass afterward. Full ESLint, TypeScript, package build and both bundle-size limits pass. Firefox and WebKit were not run.