Repository navigation
Run Node CI on pull requests - #85
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟢 Approval recommended
The trigger-only change enables fork PR checks without altering build behavior or privileges.
No open issues 🎉
What changed in this PR
Enables existing Node CI checks for pull requests, including fork PRs such as #84.
Changes:
- Adds
pull_requestalongside the existingpushtrigger. - Preserves build steps and read-only permissions.
| File | Description |
|---|---|
.github/workflows/nodejs.yml |
Enables pull-request CI while retaining push coverage. |
Review effort: Max
llastflowers
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enable the existing Node CI workflow for
pull_requestevents while preserving itspushtrigger.The workflow currently runs only on pushes to this repository. Fork pull requests such as #84 therefore never start the required
buildcheck, leaving it pending with no build run to approve or rerun.This changes only the event trigger. The build job, Node version, pinned actions, test commands, and read-only permissions remain unchanged. It uses
pull_request, notpull_request_target, to avoid running fork code in a privileged context.Validation
mainonly by changingon: pushtoon: [push, pull_request].Unblocking #84
After this PR is merged, update #84 with the latest
main(or rebase it ontomain) so its branch includes the new trigger and apull_requestsynchronization event starts the required build. This PR does not change or close #84.