Skip to content

Run Node CI on pull requests - #85

Merged
liuliu-dev merged 1 commit into
mainfrom
fix/run-ci-on-pull-requests
Oct 19, 2026
Merged

liuliu-dev merged 1 commit into
mainfrom
fix/run-ci-on-pull-requests

Conversation

@liuliu-dev

Copy link
Copy Markdown
Contributor

Summary

Enable the existing Node CI workflow for pull_request events while preserving its push trigger.

The workflow currently runs only on pushes to this repository. Fork pull requests such as #84 therefore never start the required build check, leaving it pending with no build run to approve or rerun.

This changes only the event trigger. The build job, Node version, pinned actions, test commands, and read-only permissions remain unchanged. It uses pull_request, not pull_request_target, to avoid running fork code in a privileged context.

Validation

  • Verified that the workflow differs from main only by changing on: push to on: [push, pull_request].
  • GitHub Actions will validate the existing build and tests on this branch and PR; no local checkout was used.

Unblocking #84

After this PR is merged, update #84 with the latest main (or rebase it onto main) so its branch includes the new trigger and a pull_request synchronization event starts the required build. This PR does not change or close #84.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI max review requested due to automatic review settings October 19, 2026 22:49
@liuliu-dev
liuliu-dev requested a review from a team as a code owner October 19, 2026 22:49

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The trigger-only change enables fork PR checks without altering build behavior or privileges.

No open issues 🎉

What changed in this PR

Enables existing Node CI checks for pull requests, including fork PRs such as #84.

Changes:

  • Adds pull_request alongside the existing push trigger.
  • Preserves build steps and read-only permissions.
File Description
.github/​workflows/​nodejs.yml Enables pull-request CI while retaining push coverage.

Review effort: Max

@liuliu-dev
liuliu-dev merged commit d3ee876 into main Oct 19, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants