Repository navigation
[bot] Merge master/669c602e into rel/dev - #1966
Merged
Merged
Conversation
The takeaway judge failed good takeaways against the wording of three
default criteria:
- exact_figure flagged sizes in words: "roughly a million", "the low
teens", German "etwa einer Million", "sechs- bis siebenstellig".
It now says only digits count, in any language, even when hedged.
Digits stay a violation, also next to a hedge ("roughly $1M").
- chart_walkthrough flagged a one-chart page and missed a walk-through
under a finding headline. It now says two or more charts.
- unshown_cause read "driven by new customers" as an outside cause. It
now names that phrase as a segment in the data.
calibrate_takeaway_judge.py:
- a text can carry its own `question`, the page label the judge reads;
some mistakes appear only with the real label;
- an ungraded criterion counts as a mismatch.
New calibration texts come from real outputs or keep their phrases.
Each relaxed boundary has a fail text. The README says the judge reads
the item input as the page label.
jira: QA-30019
risk: low
fix(gooddata-eval): stop the takeaway judge misreading its own criteria
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## rel/dev #1966 +/- ##
========================================
Coverage 86.96% 86.96%
========================================
Files 352 352
Lines 27781 27781
========================================
Hits 24159 24159
Misses 3622 3622 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Automated PR to perform merge from master into rel/dev with changes up to 669c602 (created by https://github.com/gooddata/gooddata-python-sdk/actions/runs/44308653112).