Skip to content

[bot] Merge master/669c602e into rel/dev - #1966

Merged
yenkins-admin merged 2 commits into
rel/devfrom
snapshot-master-669c602e-to-rel/dev
Nov 18, 2026
Merged

yenkins-admin merged 2 commits into
rel/devfrom
snapshot-master-669c602e-to-rel/dev

Conversation

@yenkins-admin

Copy link
Copy Markdown
Contributor

🚀 Automated PR to perform merge from master into rel/dev with changes up to 669c602 (created by https://github.com/gooddata/gooddata-python-sdk/actions/runs/44308653112).

myduong243 and others added 2 commits November 16, 2026 18:02
The takeaway judge failed good takeaways against the wording of three
default criteria:

- exact_figure flagged sizes in words: "roughly a million", "the low
  teens", German "etwa einer Million", "sechs- bis siebenstellig".
  It now says only digits count, in any language, even when hedged.
  Digits stay a violation, also next to a hedge ("roughly $1M").
- chart_walkthrough flagged a one-chart page and missed a walk-through
  under a finding headline. It now says two or more charts.
- unshown_cause read "driven by new customers" as an outside cause. It
  now names that phrase as a segment in the data.

calibrate_takeaway_judge.py:
- a text can carry its own `question`, the page label the judge reads;
  some mistakes appear only with the real label;
- an ungraded criterion counts as a mismatch.

New calibration texts come from real outputs or keep their phrases.
Each relaxed boundary has a fail text. The README says the judge reads
the item input as the page label.

jira: QA-30019
risk: low
fix(gooddata-eval): stop the takeaway judge misreading its own criteria
@yenkins-admin
yenkins-admin merged commit 700eb76 into rel/dev Nov 18, 2026
1 check passed
@yenkins-admin
yenkins-admin deleted the snapshot-master-669c602e-to-rel/dev branch November 18, 2026 12:56
@coderabbitai

coderabbitai Bot commented Nov 18, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: f6236054-23e9-48b9-84bf-cd23653b2010

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@codecov

codecov Bot commented Nov 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.96%. Comparing base (a607c7a) to head (669c602).
⚠️ Report is 657 commits behind head on rel/dev.

Additional details and impacted files
@@           Coverage Diff            @@
##           rel/dev    #1966   +/-   ##
========================================
  Coverage    86.96%   86.96%           
========================================
  Files          352      352           
  Lines        27781    27781           
========================================
  Hits         24159    24159           
  Misses        3622     3622           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants