Repository navigation
Use full sync when LDAP entries have no modify timestamp - #284
Open
DifanZhang wants to merge 2 commits into
Open
DifanZhang wants to merge 2 commits into
DifanZhang wants to merge 2 commits into
Conversation
Some LDAP servers, such as Google Secure LDAP, do not return modifyTimestamp. The fallback from #224 set the map timestamp to 0, so later runs did an incremental search with modifyTimestamp>=19700101000001Z. That search found no entries, and the cache did not change. Now, if any entry has no modifyTimestamp (or whenChanged for AD), the map gets no timestamp. Each update then does a full sync. The timestamp attribute name is matched without case. A stored timestamp of 0 also causes a full sync, which repairs hosts that ran the earlier fallback. Fixes #127
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment has been minimized.
This comment has been minimized.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some LDAP servers, such as Google Secure LDAP, do not return modifyTimestamp. The fallback from #224 set the map timestamp to 0, so later runs did an incremental search with modifyTimestamp>=19700101000001Z. That search found no entries, and the cache did not change.
Now, if any entry has no modifyTimestamp (or whenChanged for AD), the map gets no timestamp. Each update then does a full sync. The timestamp attribute name is matched without case. A stored timestamp of 0 also causes a full sync, which repairs hosts that ran the earlier fallback.
Fixes #127