Repository navigation
fix(scans): queue accepted hackers who can't check in as walk-ins - #360
Merged
Merged
Conversation
An accepted hacker whose RSVP is pending, declined, withdrawn or forfeited was refused by both scanners: check-in for the RSVP, walk-in for being accepted. The walk-in scan now refuses only people check-in would let in, using one shared rule, and queues everyone else. Promotion from the queue now also clears a withdrawn or forfeited RSVP at check-in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
An accepted hacker whose RSVP isn't confirmed (pending, declined, withdrawn or forfeited) was refused by both scanners:
So volunteers would send them back and forth, and only a super admin's Admit by email could let them in. In prod tonight that's 459 people: 395 pending, 51 declined, 13 withdrawn.
This change makes the walk-in scan refuse only the people check-in would let in, using one shared function (
checkInRefusal), and queues everyone else. The two scanners can no longer disagree.Changes
cmd/api/scans.gocheckInRefusal. The check-in branch and the walk-in branch both call it.checkInRefusalsays they can check in.internal/store/walkins.go: removesEnqueue's "already accepted → don't queue" shortcut. The handler now owns the rule. Without this, the handler change alone would record a walk-in scan and answer 201 without queueing anyone.claude.md: the walk-in rule is updated.As before, queueing makes the application
waitlisted. Promotion makes itacceptedagain. The portal already shows a queued walk-in their position, and they get the queued email.Also in this PR: a chat UI tweak
bg-surface/40→/70), so the starter questions are readable over the page. Dark mode keeps its own 40% fromindex.css.Tests
TestIntegrationWalkInsEnqueueUnclaimedAcceptance): an accepted hacker with a pending RSVP is queued, iswaitlistedwhile queued, and is then promoted withPromotedWalkInset. It runs in thedb-integrationCI job; it wasn't run locally.go test -race ./...passes locally.Deploying (event starts 6am Nov 7)
This branch is based on
v0.27.0, notmain. Do not merge release PR #358 this weekend: it ships #357 and #359, and #359 needs migration 124, which isn't applied to prod. The container never runs migrations.18173befa) asv0.27.1and push the tag.harp-prod-us-central1builds and swaps only the image, so min 3 / max 40 / CPU always on stay as they are. No migration is needed.mainso the fix isn't lost. release-please's manifest still says0.27.0, so check the version it proposes next.Things to know
status(waitlisted) differs from theirreleased_status(accepted), so a release would send them a decision email. Existing walk-ins already behave this way.🤖 Generated with Claude Code