Repository navigation
Conversation
filepath.Walk gives Windows paths with backslashes, but SearchFiles kept only paths containing matchSubPath+"/": no file of a manifest directory was found and the generated chart had no templates (an assertion error up to v0.27.0, a silently empty render since helmfile#207). Match on the path with the OS separator replaced by "/". The check is in SearchFileOpts.matches(path, sep), tested with Unix and Windows paths. Fixes helmfile#222 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: carlo tadiello <carlo.tadiello@corvina.io>
catadiel
force-pushed
the
fix/search-files-windows-paths
branch
from
November 18, 2026 16:10
3504928 to
81f12e1
Compare
Author
|
Checked with the latest helmfile release as well. helmfile v1.8.4 (chartify v0.30.0) rebuilt with this branch in place of chartify (
🤖 Generated with Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #222.
SearchFilesmatched the sub path withstrings.Contains(path, matchSubPath+"/"), butfilepath.Walkgives Windows paths with backslashes: no file of a manifest directory was ever found, and the generated chart had no templates (an assertion error up to v0.27.0, a silently empty render since #207).The match is now done on the path with the OS separator replaced by
/. The check moved to a smallSearchFileOpts.matches(path, sep)so the Windows case is tested on the Linux CI too:TestSearchFileOptsMatches: Unix and Windows paths (the Windows cases fail with the previous logic);TestSearchFilesFindsManifests:SearchFileson a real temp dir.Checked on Windows: helmfile 1.7.0 rebuilt with chartify v0.27.0 + this change renders the same resources as on Linux (306 for a helmfile of about 30 releases, most of them manifest directories), where the released build fails or renders them empty.
🤖 Generated with Claude Code