Repository navigation
Fix omerotools - #157
Fix omerotools#157
Conversation
|
Thanks @loicsauteur! ❤️ 🧾 An issue like this definitely reveals the need for being able to to run tests on the code. Since we can't properly emulate the (*that separate function should be string-based only, making it approachable for pytest 🧪) Would you like to work on it, otherwise I'd put it onto our list for the next Coding 🧑💻 Session (you're welcome to join if you wish)? |
|
I'd welcome the opportunity to join one of your coding sessions and work on this. As I am not really used to working on a collaborative project, I'm happy about the pointers and how-to. E.g.:
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## devel #157 +/- ##
====================================
+ Coverage 33% 35% +3%
====================================
Files 25 25
Lines 1806 1823 +17
====================================
+ Hits 591 645 +54
+ Misses 1215 1178 -37 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
8c5ac37 to
87f5674
Compare
Removed 'image_ids = ...' is immediately overwriten by the subsequent line. Removed lines ('image-' URL handling) are handled in the 'elif' before.
Clarified that it works for Dataset IDs or Image IDs URLs. Removed that it handles Dataset IDs directly (which it does not to my knowledge.
Import image did not raise file error if it did not exist.
87f5674 to
6e719a0
Compare
This function is part the refactoring of parse_url. It takes an URL and OMERO type to return a list of string IDs. Along with a test.
This function is part the refactoring of parse_url. It takes an URL and return a list of string IDs and the OMERO type (Project, Dataset or ID). Along with a test.
The string handling of parse_url happens now in other functions. The logic stays the same. In addition, it raises an NotImplementedError for Project-URLs.
|
I added the refactoring of the 2 additional functions with their tests (in I also added a very basic test function for Important: I have not tested the modified |
|
Thanks @loicsauteur for the updates! I ran the CI checks now (this will happen automatically once your first PR is merged into the repository) and two of them are failing: That's due to one of the parameters not being explained in the function's docstring. This is caused by using statements that are Python 3 only (which explains why the |
Thanks @ehrenfeu: Yes, I just tried to test in Fiji and ran into an error... I will lint (did not work with the PyCharm plugin), and check that it is compatible with Python 2.7 🙄. |
|
Linting 🕵️ is fine now ✅ but the Python 2 🐍🐍 test is still failing: |
Yes, saw it. Python 2.7 isn't really groovy 😉 |
Raise FileNotFoundError for Python 3.x and IOError for Python 2.7
|
OK. I added also It is really cool and great that you have those CI workflows! And also the documentation in the project! |
PR for issue #154
parse_urlparse_urlFileNotFoundErrorforupload_image_to_omeroAll changes done with no testing. I was unable to create an env from poetry (sorry).