Repository navigation
Conversation
http3.Transport had a TLSClientConfig field of its own since the quic-go v0.51.0 sync. Nothing set it, and it hid Options.TLSClientConfig, so InsecureSkipVerify, RootCAs and client certificates were ignored over HTTP/3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Over HTTP/3 the client's TLS settings are ignored. This fails against a server with a self-signed certificate:
The same goes for
SetRootCertsFromFileand client certificates.The cause is in
internal/http3/transport.go. Since the quic-go v0.51.0 sync (8067517)Transporthas its ownTLSClientConfigfield next to the embedded*transport.Options. Nothing sets it, and it shadowsOptions.TLSClientConfig, so the dial always gets a nil config. Removing the field makes it read the client's config again.TestHTTP3UsesTheClientTLSConfigstarts a local HTTP/3 server with the test certificate and fails on master with the error above. It passes with this change, and./internal/http3passes too.