Repository navigation
Conversation
napetrov
requested review from
ethanglaser,
homksei,
mihaic and
yuejiaointel
as code owners
October 23, 2026 22:53
g++-11 and clang++-15 ivf=OFF build the same sources as their ivf=ON twins minus the IVF tests/utils/benchmark files. g++-12 keeps ivf=OFF since it is its only job. Part of #432 Signed-off-by: Nikolay Petrov <nikolay.a.petrov@intel.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Linux CI runs two RelWithDebInfo jobs that build nothing their ivf=ON twin does not also build. This PR removes them.
The change adds two
excludeentries. Job names stay the same.Evidence
SVS_EXPERIMENTAL_ENABLE_IVFonly adds things. It never takes anything away:CMakeLists.txt:81-84: includescmake/mkl.cmakeand adds-DSVS_HAVE_MKL=1. Nothing ininclude/,tests/,utils/,benchmark/orexamples/readsSVS_HAVE_MKL.cmake/options.cmake:160-164:-DSVS_ENABLE_IVF=0/1.grep -rn SVS_ENABLE_IVF include/ tests/ utils/ examples/finds nothing exceptSVS_ENABLE_IVF_EXAMPLES, a separate option. The only readers are inbenchmark/src/main.cpp:30,56. Both are#if SVS_ENABLE_IVFblocks with no#else, so the OFF build is the ON build minus the IVF registrations.tests/CMakeLists.txt:192,222,utils/CMakeLists.txt:55andbenchmark/CMakeLists.txt:52onlylist(APPEND ...)orcreate_utilityIVF sources.build-linux-arm.yml) and macOS do not use an ivf axis, so neither is affected.Measured cost: medians over the last 40 green
build-linuxruns. There were 236 runs in the last 30 days (206pull_request, 30push).actionlint1.7.7 passes. It reports 4 shellcheck notes, andmainhas the same 4.Merge danger
Part of #432
🤖 Generated with Claude Code