Repository navigation
[raft] Replicate the membership of Raft groups - #1775
Merged
Merged
Conversation
MariemBaccari
force-pushed
the
cluster_membership
branch
10 times, most recently
from
October 14, 2026 14:00
654d774 to
b905079
Compare
MariemBaccari
changed the title
MariemBaccari
marked this pull request as ready for review
October 15, 2026 13:41
mickmis
reviewed
Oct 20, 2026
MariemBaccari
force-pushed
the
cluster_membership
branch
3 times, most recently
from
October 21, 2026 10:09
6e5d329 to
6de094d
Compare
MariemBaccari
marked this pull request as draft
October 22, 2026 13:28
MariemBaccari
force-pushed
the
cluster_membership
branch
2 times, most recently
from
October 23, 2026 12:32
350e321 to
adedbb8
Compare
MariemBaccari
marked this pull request as ready for review
October 23, 2026 12:41
mickmis
approved these changes
Oct 26, 2026
mickmis
left a comment
mickmis
left a comment
Contributor
There was a problem hiding this comment.
LGTM, but feels like there is something missing?
| } | ||
|
|
||
| // addNode records nodeID as a member described by mem. | ||
| func (m *membership) addNode(nodeID uint64, mem member) { |
Contributor
There was a problem hiding this comment.
This does not add a peer to the transport, is it expected?
Also, there is nothing that removes a node, is it expected?
Contributor
Author
There was a problem hiding this comment.
Yes this PR is only for membership replication. #1780 implements additions and removals :)
MariemBaccari
force-pushed
the
cluster_membership
branch
2 times, most recently
from
October 26, 2026 20:23
c2fd4ed to
c142788
Compare
MariemBaccari
force-pushed
the
cluster_membership
branch
from
October 26, 2026 20:33
c142788 to
a9d487d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR partially addresses #1719 by adding new
membershipandsnapshotstructures to support config changes.