Repository navigation
[aux/payloads] Define proto - #1829
Merged
Merged
Conversation
MariemBaccari
force-pushed
the
aux_proto
branch
from
October 28, 2026 13:22
1a1856a to
d2cb046
Compare
mickmis
approved these changes
Oct 29, 2026
mickmis
left a comment
mickmis
left a comment
Contributor
There was a problem hiding this comment.
One thing to be wary of in general: if the go model is a pointer, then the equivalent in the proto would be to set the field as optional.
And the first two comments are applicable to other PRs too.
Otherwise LGTM.
Contributor
There was a problem hiding this comment.
I don't think payloads/ is an appropriate subfolder. I'm not sure what would describe best the content, but here are some suggestions that I would find more appropriate:
consensusraftraftnode
Contributor
Author
There was a problem hiding this comment.
I went with raft, seems appropriate enough :)
Co-authored-by: Mickaël Misbach <mickael.misbach@orbitalize.com>
Co-authored-by: Mickaël Misbach <mickael.misbach@orbitalize.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses feedback under #1765 by defining a proto file for aux requests.
It implements #1709.