Repository navigation
[raft] Define the admin interface of Raft groups - #1892
Closed
MariemBaccari wants to merge 1 commit into
Closed
MariemBaccari wants to merge 1 commit into
MariemBaccari wants to merge 1 commit into
Conversation
MariemBaccari
force-pushed
the
admin_interface_raft
branch
from
November 2, 2026 17:02
f5d9484 to
65ccd4f
Compare
MariemBaccari
force-pushed
the
admin_interface_raft
branch
2 times, most recently
from
November 4, 2026 08:21
a4755f7 to
2f27cc9
Compare
MariemBaccari
force-pushed
the
admin_interface_raft
branch
from
November 4, 2026 14:20
2f27cc9 to
cf120ed
Compare
This was referenced Nov 4, 2026
mickmis
reviewed
Nov 5, 2026
mickmis
left a comment
mickmis
left a comment
Contributor
There was a problem hiding this comment.
Why is an interface required here?
Go-idiomatic code would define an interface alongside its consumer. So I'd actually see that piece of code belong more in #1777.
But if the implementer of the interface is anyway strongly coupled with its consumer, and that there are no alternative implementation planned, I think that is just introducing unnecessary abstractions. But I'm missing something?
| type Membership struct { | ||
| // ClusterID identifies the group within the cluster. It is identical on all the members of the group. | ||
| ClusterID uint64 | ||
| LeaderID uint64 |
Contributor
Author
There was a problem hiding this comment.
It's the ID of the leader of the Raft group.
Contributor
Author
|
As discussed offline, this interface is not needed anymore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR partially addresses #1719. It adds
admin.RaftGroup, the Go interface for managing Raft group membership. It will be implemented, in follow-up PRs by the server and the client.