[the-glu]

This PR contribute to #1558

It does remove test_version and token tests from the prober.

Versions test have already been implemented in scenarios.astm.utm.dss.pool_info.PoolInfo and token tests are not need anymore, so nothing new is added.

[BenjaminPelletier]

Could this just be an additional step in pool_info (comparing aux version endpoint with versioning-API endpoint)?

[the-glu]

Could this just be an additional step in pool_info (comparing aux version endpoint with versioning-API endpoint)?

I wanted to split them, as it's not really something for 'pooling' information, and in term of "global plan", test_token_validation should be relocated there as well no?

[BenjaminPelletier]

Could this just be an additional step in pool_info (comparing aux version endpoint with versioning-API endpoint)?

I wanted to split them, as it's not really something for 'pooling' information, and in term of "global plan", test_token_validation should be relocated there as well no?

The pool is composed of DSS instances, and the version of each of those instance is a critical piece of information about the composition of the pool; that's why the version of each instance is retrieved and noted in the pool_information scenario. I think a quick extra query to verify the version obtained is consistent is probably a good measure of pool health, especially since we already know we're working with InterUSS implementations of the DSS.

I think test_token_validation should be removed entirely as it no longer serves a useful purpose.

[the-glu]

The pool is composed of DSS instances, and the version of each of those instance is a critical piece of information about the composition of the pool; that's why the version of each instance is retrieved and noted in the pool_information scenario. I think a quick extra query to verify the version obtained is consistent is probably a good measure of pool health, especially since we already know we're working with InterUSS implementations of the DSS.

Ok, I just removed them, it's already done on the pool side. I didn't saw the existing version checks because they are in a different client (InterUSSVersioningClient instead of InterUSSDSSClient), is that on purpose?

I added the PoolInfo scenario in the dss_probing suite.

I think test_token_validation should be removed entirely as it no longer serves a useful purpose.

I also removed those ones in this PR directly, should we remove the endpoint in the DSS as well? I seems that was the only place that endpoint was used.