Repository navigation
Stop skipping platform.yml's apply when site.yml has nothing to do - #13
Merged
Merged
Conversation
platform-apply had no status check, so GitHub added success(), which also counts platform-dry-run's own needs. site-dry-run and site-apply are skipped on every merge that leaves site.yml alone, so since c36dd1b platform.yml was only applied when site.yml ran in the same merge. #12's allowlist was the first merge to hit it. Check !cancelled() and the dry run's result instead, as platform-dry-run does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
platform-applywas skipped on the merge of #12 (run):platform-dry-runsucceeded, but the apply never reached theproductionapproval, so the sf/sf28443rules on lith-1 were never applied.Why
platform-apply'sif:has no status check, so GitHub addssuccess(). That counts every job up the chain, not just the directneeds. Since c36dd1b,platform-dry-runneedssite-dry-runandsite-apply, which are skipped on every merge that leavessite.ymlalone. Soplatform.ymlhas only been applied whensite.ymlran in the same merge (6719ee6 on 2026-10-19). #12 was the first platform-only merge since then:platform-dry-rundoesn't have the problem: it uses!cancelled()and checks each result by name.Change
platform-applynow runs on!cancelled() && needs.platform-dry-run.result == 'success', plus the conditions it had. The dry run already requires every check to pass, and the job keepsenvironment: production, so the apply still waits for a required reviewer.After merging
This touches
.github/workflows/ci.yml, which counts as a change for both playbooks:site.yml: dry run, then an apply waiting for approval. The dry run should show no changes; approve it anyway, since a rejectedsite-applystopsplatform.yml.platform.yml: dry run, then the apply, which this time should reach the approval. It should show only Let sf and sf2 push metrics and logs to the monitoring hub #12's twomonitoring ingestrules on lith-1 (103.232.206.165,103.232.206.162).Checked
actionlintpasses.🤖 Generated with Claude Code