Repository navigation
Reduce bit-vector append overhead - #13
Open
adamant-pwn wants to merge 1 commit into
Open
adamant-pwn wants to merge 1 commit into
adamant-pwn wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bulk bit-vector construction repeatedly appends packed words. Share the growth path for aligned and overflowing appends, remove the cached last-word pointer, and use unsigned shift counts. Assigning the packed value after emplace_back() avoids passing it by reference into vector growth, removing spills in the measured GCC loop. Existing builder calls require no changes.
In SSHash's encode_strings, median CPU-cycle ratios versus the original append implementation were:
Measured on a Ryzen 9 7945HX with -O3 -DNDEBUG -mavx2 -mbmi2, using seven randomized paired blocks per workload and at least 0.55 seconds per sample. Long inputs contained 1,800 records; short inputs contained 60,000. Timing includes stream parsing and encoding, with file I/O and packed-output checks outside the measured section.