Repository navigation
Fix the two Playwright e2e tests that fail on main - #67
Conversation
The storyboard mobile overlap test queries .homepage-workflow-scene-copy, a class 5ec16a2 dropped when it moved the homepage styles to Tailwind utilities. The test threw before reaching its geometry assertions. Add a data-testid to the scene copy wrapper, matching the repo selector convention, and point the test at it.
2a9c2e2 moved the save status indicator out of document-status-stack into a fixed top-left corner, but did not carry over the offset that drops the stack below a top notice. On a 390px viewport the conflict banner spans x 8-382 and y 12-240, covering the corner at x 12-40, y 12-40. Share one top-offset class between both fixed status affordances so they cannot drift again. Retarget the overlap test at the save status corner, which is where the save status now lives; document-status-stack holds only the review handoff button and watcher notice, neither of which renders without a watcher, so it was empty and reported hidden.
|
[orchestrator e2fcf357] Build record, as reported by build-27. What the issue plannedMake the two Playwright tests that fail on What was builtBoth failures were stale test hooks left behind by upstream refactors, not tests that Test 1 — The test looked up the scene copy wrapper as The fix restores the hook in the repo's own convention: Why Test 2 — Two separate problems, both traced to the same upstream commit. The stale selector: when the test was written in The layout defect: the same commit gave the new corner a bare
Per the repo's Prove It pattern I retargeted the assertion first and watched it fail on the The fix hoists the offset both fixed status affordances need into one The test is retargeted at Why the build differs from the issueIt does not differ in outcome. Two points worth flagging. First, the issue's Files list named Second, the issue anticipated that a fix might be confined to the specs. Both fixes needed a Tests addedNone. This issue is about two existing tests. Both were repaired in place and neither was
Left undoneNothing in scope. Three things observed and deliberately not acted on, all outside this issue:
|
|
[orchestrator e2fcf357 overnight] Final build record for issue #27, replacing the earlier build-record comment on this PR. One measurement in that comment was wrong and is corrected here; the code is unchanged. Reviewer What the issue plannedMake the two Playwright tests that fail on What was builtBoth failures were stale test hooks left behind by upstream refactors, not tests that Test 1 — The test looked up the scene copy wrapper as The fix restores the hook in the repo's own convention: Why Test 2 — Two separate problems, both traced to the same upstream commit. The stale selector: when the test was written in The layout defect: the same commit gave the new corner a bare
Per the repo's Prove It pattern I retargeted the assertion first and watched it fail on the The fix hoists the offset both fixed status affordances need into one The test is retargeted at Why the build differs from the issueIt does not differ in outcome. Two points worth flagging. First, the issue's Files list named Second, the issue anticipated that a fix might be confined to the specs. Both fixes needed a Tests addedNone. This issue is about two existing tests. Both were repaired in place and neither was
Left undoneNothing in scope. Three things observed and deliberately not acted on, all outside this issue:
Review outcome
The three findings are resolved as follows. The wrong band measurement is corrected above and Merged under Mauria's overnight merge grant of 2026-09-06, which authorizes the orchestrator to |
Both tests had been failing since upstream refactors moved the elements they query, so neither was reaching the geometry it asserts. Neither is deleted and no assertion is loosened.
Closes #27
The storyboard test queried
.homepage-workflow-scene-copy, a class commit 5ec16a2 dropped when it moved homepage styles to Tailwind, so it threw before any measurement; the hook is restored as adata-testidand the test points at it. The stale-write test querieddocument-status-stack, which commit 2a9c2e2 emptied when it moved the save status into a new top-left corner. Retargeting it at that corner made it fail on real geometry: at 390px the conflict banner spans y 12-240 directly over the save status. That is a genuine layout defect, so the fix is in the layout, with one shared top-offset constant between the two fixed status affordances, not in the assertion.Verification: full
pnpm test:e2egreen three consecutive runs at 48 passed;pnpm checkpasses.One variance:
criticmarkup-review.spec.ts:401failed once under parallel load, then passed alone and on three full-suite reruns. That spec references nothing this branch touches; it was not bisected against a cleanmain.