Skip to content

feat(evaluations): send the AI Config link on reconcile - #301

Closed
donei003 wants to merge 1 commit into
cursor/eval-served-variation-700bfrom
cursor/eval-config-link-700b
Closed

donei003 wants to merge 1 commit into
cursor/eval-served-variation-700bfrom
cursor/eval-config-link-700b

Conversation

@donei003

@donei003 donei003 commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Overview

Stacked on #299 (cursor/eval-served-variation-700b), which targets main. The diff is only the link fields. Draft, and it waits on #299.

When run() is seeded from an AIConfig, the offline-evaluation POST and the PATCH send:

  • configKey
  • variationKey
  • variationVersion — the variation's version, not the evaluation's version and not the model-config version

An explicit variation sends the latest management-API version. An omitted variation sends the served _ldMeta.version, including when that version is older than the latest.

A generation override replaces the content for the run and the link is still sent. Run create does not take the link. result.url stays {ui}/projects/{project}/ai/evaluations/{evaluationId}/runs/{runId}.

Decisions

A run with no ai_config omits the three fields. It does not send null, so a later generation-only reconcile of a key that was linked does not clear that link. Say if that run should unlink.

Parameter overrides still merge key by key, as on the parent PR.

Testing

uv run pytest packages/client/tests -q

2221 passed. No public signature change, so the API report is unchanged.

Open in Web Open in Cursor 

@donei003
donei003 added this pull request to stack #300 November 12, 2026 21:10
@cursor

cursor Bot commented Nov 12, 2026

Copy link
Copy Markdown

bugbot run

@cursor
cursor Bot force-pushed the cursor/eval-config-link-700b branch from 259b78c to 6246f20 Compare November 12, 2026 21:17
@cursor

cursor Bot commented Nov 12, 2026

Copy link
Copy Markdown

bugbot run

POST and PATCH of an offline evaluation send configKey, variationKey,
and variationVersion. A generation override replaces the content and
keeps the link. The run URL is unchanged.

Co-authored-by: Dylan O'Neill <donei003@users.noreply.github.com>
@donei003
donei003 force-pushed the cursor/eval-config-link-700b branch from 6246f20 to 52fac95 Compare November 16, 2026 20:28
@donei003 donei003 closed this Nov 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants