Repository navigation
Conversation
- Give SparqlItemSelector a pageSize option, defaulting to the larger of the stage’s batchSize and 1000; the stage cuts each page into batches, so it no longer waits on a SELECT before every batch - Read each page in full before yielding it, and report the outcome to the timeout policy after the body is read, so a failure mid-body counts as one - Reject a non-integer pageSize or batchSize, and a query LIMIT 0 at construction - Keep the SHACL sampler at one page per batch, so a sample fetches no rows it never yields BREAKING CHANGE: SparqlItemSelector no longer pages in the stage’s batchSize. An endpoint that silently caps SELECT results below 1000 rows now ends pagination after the first page; add a LIMIT to the selector query or set pageSize to stay under the cap.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1066
SparqlItemSelectorpaged roots in the stage’sbatchSize, so a stage waited on a SELECT before every batch. It now fetches larger pages and the stage cuts them into batches.pageSizeoption. By default a page holds 1000 bindings, or thebatchSizewhen that is larger. ALIMITin the selector query still wins.okas soon as the headers arrived, so a body that failed halfway still counted as a success.pageSizeandbatchSizemust be positive integers. A queryLIMIT 0is rejected when the selector is built, not on its first run.pageSize: batchSize). Its selector caps results withmaxResults, so a page of 1000 would fetch about 20 times the rows it yields.Breaking: an endpoint that silently caps SELECT results below 1000 rows now stops pagination after the first page. Add a
LIMITto the selector query or setpageSize.Not included: fetching the next page while the stage works through the current one. The stage still waits for one SELECT every 1000 roots.