Repository navigation
ci: move the Cygwin build from AppVeyor to GitHub Actions - #848
Merged
Merged
Conversation
The Cygwin job took 4-6 minutes of each AppVeyor build, and AppVeyor runs one build at a time. The new windows-cygwin job runs the same autotools build on GitHub Actions, in parallel with the other jobs, and also builds with -Werror, checks the installed files and smoke-tests hidtest. AppVeyor keeps the Visual Studio 2015 MSBuild jobs. Assisted-by: claude-code:claude-opus-5-5
configure.ac runs AC_PROG_CXX; without a C++ compiler libtool's C++ preprocessor check fails configure under Cygwin. Assisted-by: claude-code:claude-opus-5-5
Assisted-by: claude-code:claude-opus-5-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the Cygwin build from AppVeyor to a new
windows-cygwinjob in GitHub Actions.The Cygwin job was the slowest part of every AppVeyor build: 4-6 minutes, about 3 of them spent upgrading the preinstalled Cygwin, while each MSBuild job takes under a minute. AppVeyor runs one build at a time, so builds also queue behind each other (up to 10 minutes for recent PRs), and AppVeyor was the last check to report on most pushes and PRs.
Coverage compared with the AppVeyor job:
./bootstrap && ./configure && make, building the Windows backend (libhidapi.la, shared and static) andhidtest.-Wall -Wextra -pedantic -Werror -Wformat-signednessas the other GCC jobs. Cygwin is the only Windows toolchain in CI with a 64-bitlong, so its warnings can differ from MinGW's.make install, then checks the installed DLL, import library, header and pkg-config files.hidtestas a runtime smoke test under Cygwin. The hosted runner exposes a virtual HID mouse, so this enumerates a real device and rebuilds its report descriptor from preparsed data. The devicehidtesttries to open isn't there, so exit code 1 ("unable to open device") is the expected result.AppVeyor keeps the two Visual Studio 2015 MSBuild jobs, the oldest MSVC in CI. With only MSBuild left, the
for:matrix in.appveyor.ymlis no longer needed.Timing, measured on this branch and on the last five
masterbuilds:builds.ymlwindows-cygwinitself: 1.9-2.3 min)So all checks report about 2.5 minutes after a push instead of 5-8. Each AppVeyor build also holds AppVeyor's single build slot for about a minute instead of about six, which shortens the queue for builds waiting behind it.
Validation:
builds.ymljobs pass; the log shows the warning flags on bothhid.ccompiles and on thehidtestlink.After merging,
windows-cygwinshould be added to the required status checks formaster. Until then a Cygwin failure won't block a merge; today it does, throughcontinuous-integration/appveyor/pr.Assisted-by: claude-code:claude-opus-5-5
Generated by Claude Code (Claude Opus 5.5).