Repository navigation
Conversation
Trio uploads temp basal durations in whole minutes, so a temp cancelled within its first minute arrives with duration 0. Only a temp basal without a duration is drawn as running for 30 minutes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the newest Temp Basal in Nightscout had a duration of 0, LoopFollow drew it as running for 30 minutes and the Basal row showed scheduled → temp, even though the pump was back on scheduled basal. Trio uploads durations in whole minutes, so a temp cancelled within its first minute (for example when switching to Basal Testing on Trio dev) arrives with duration 0. A duration of 0 now ends the temp at its start; a temp basal without a duration is still drawn as running for 30 minutes.
Tested in the simulator with Trio dev and a simulated Omnipod DASH pod, and checked against Nightscout data from real Loop and Trio setups, where durations are always present and 0 only shows up for a temp cut short by a pod change.
Before and after, same Nightscout data (scheduled 0.8 U/h, a 0.5 U/h temp cancelled within its first minute):