Repository navigation
Normalize nested installer paths - #6552
Open
Kaleb Luedtke (Trenly) wants to merge 13 commits into
Open
Kaleb Luedtke (Trenly) wants to merge 13 commits into
Kaleb Luedtke (Trenly) wants to merge 13 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Kaleb Luedtke (Trenly)
marked this pull request as ready for review
September 22, 2026 13:22
Kaleb Luedtke (Trenly)
marked this pull request as draft
September 22, 2026 13:23
Kaleb Luedtke (Trenly)
marked this pull request as ready for review
September 22, 2026 13:23
This comment has been minimized.
This comment has been minimized.
JohnMcPMS
reviewed
Sep 29, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…e-nested-installer-paths
Store nested installer file paths in a wrapper that normalizes separators on assignment and exposes UTF-8/UTF-16 path accessors. Update validation, serialization, workflow consumers, and tests for the wrapped path type. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Rename normalized path accessors to string and wstring and update their consumers. Correct Unicode test literals and cover overlong UTF-8 separator sequences. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Cover Unicode paths, normalized duplicate paths, and traversal rejection through WinGetUtil manifest creation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
JohnMcPMS
reviewed
Oct 21, 2026
Member
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
JohnMcPMS
previously approved these changes
Oct 22, 2026
Member
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
11 tasks
…est-winget-cli # Conflicts: # doc/ReleaseNotes.md Co-authored-by: Trenly <12611259+Trenly@users.noreply.github.com>
Co-authored-by: Trenly <12611259+Trenly@users.noreply.github.com>
Copilot/merge latest winget cli
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📖 Description
Store nested installer RelativeFilePath values in a lightweight wrapper around std::filesystem::path. The wrapper normalizes preferred separators when values are assigned and exposes UTF-8, UTF-16, and path accessors. Update validation, serialization, installer workflows, and tests to use the normalized path representation.
🔗 References
Resolves #6551
🔍 Validation
git diff --cached --check.msbuild src\AppInstallerCLITests\AppInstallerCLITests.vcxproj /p:Configuration=Debug /p:Platform=x64 /p:SolutionDir=E:\winget-cli\src\ /m:1 /nodeReuse:false /nologo /v:minimal; SharedLib and CommonCore built, but the build failed in AppInstallerRepositoryCore because the Visual Studio process heldsrc\AppInstallerRepositoryCore\x64\Debug\pch.pchopen (C1083: permission denied).✅ Checklist
🤖 AI Assistance
📋 Issue Type