Repository navigation
Point every link at the renamed repository, h5p-toolkit - #233
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 52 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
…prompt as it was typed (#232)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #232.
The repository is now
missing-elements/h5p-toolkit. This points what it says about itself at the new name. GitHub redirects the old addresses, so nothing published breaks meanwhile.What changes
github.com/missing-elements/h5p-offline-playerandapi.github.com/repos/…address now namesh5p-toolkit, but for one quoted prompt (below). They are in:docs/,design/, SECURITY.md and CONTRIBUTING.md;repository,homepageandbugsfields of all ten packages, which npm and the VS Code Marketplace show from each package's next release.npx skills add missing-elements/h5p-toolkitin the README and the embed and verify READMEs.h5p-toolkit-workspace;design/licensing.md: like the npm names, the repository's name says who owns it.demo/og-image.png, rendered again withpnpm demo:og: its foot reads github.com/missing-elements/h5p-toolkit.Kept on purpose
docs/setup.mdand the demo's setup page: it records what was typed, and the old address still redirects.@missing-elements/h5p-offline-playeris the player, and every package keeps its name.context.platform(h5p-offline-player <version>) and the embed'spostMessagecontext, both promised in docs/compatibility.md.h5p-offline-player.vercel.app, and its pages' titles and brand, which name the player.missing-elements/h5p-toolkit, and its badge says "resource not found", until something is installed under the new name. The old page keeps its 23 installs. Move both once the new page exists.Tested
pnpm install --frozen-lockfile,pnpm typecheckandpnpm test:unitpass:github.com/missing-elements/h5p-offline-playeris left. The remaining mentions ofh5p-offline-playerare the npm names, the two promised strings, the site's address, page titles and brand, and file names.The org site and the organisation's profile README get the same change in their own PRs:
Summary by cubic
Points every link at the renamed repository,
missing-elements/h5p-toolkit. GitHub redirects the oldh5p-offline-playeraddresses, so nothing published breaks.repository,homepage, andbugsfields of all ten packages.npx skills addcommands, the workspace package name, and the core-sync user agent.context.platform, the embed'spostMessagecontext) as-is.design/licensing.mdthat the repository name, like the npm scopes, identifies the owner.Written for commit aea7064. Summary will update on new commits.