Repository navigation
Pin h5p-author 0.10.1 - #56
Merged
Merged
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
No issues found across 2 files
Tip: cubic could auto-approve low-risk PRs like this, if it thinks it's safe to merge. Learn more
View guided diff | Turn on auto-fix | Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #55.
h5p-author 0.10.1 (missing-elements/h5p-toolkit#207) changes only the skill's route 4. A chat that built nothing now writes the build page's link itself, with the source as readable JSON, which the build page reads since #54. The person no longer gets a code block to open with Preview.
What changes
package.jsonand the lockfile move@missing-elements/h5p-authorfrom 0.10.0 to 0.10.1. The lockfile change is the five lines of that entry, with the integrity npm gives for 0.10.1. Its dependencies are the same as 0.10.0's./h5p/skill/h5p-author.zipand/h5p/skill/h5p-author-chatgpt.ziphold 0.10.1's skill, and the plugin'splugin.jsonsays 0.10.1. Against 0.10.0's, onlyreferences/build/browser.mdchanges./h5p/bundles/index.jsonand the pages name 0.10.1. The build page's type files and the bundles are as in 0.10.0, andh5p-author-build.tar.gzholds 0.10.1's tool.Tested
pnpm install --frozen-lockfile,pnpm build(which type-checks, and checks the tool's--version) andpnpm typecheckpass./h5p/build/types/equal it too, and no page or JSON file in the built site names 0.10.0.h5p-author.mjs --versionprints 0.10.1 and pack 1.1.0. It built a True/False with--libraries partsthat the verifier passes.Summary by cubic
Pins
@missing-elements/h5p-authorfrom 0.10.0 to 0.10.1 and brings the bundled skill zips, archive, pages, and bundle index in line with the new version.0.10.1 changes only skill route 4: a chat that built nothing now writes the build page's link itself, with the source as readable JSON, instead of asking the person to open a code block with Preview. Dependencies are unchanged from 0.10.0.
Verified
pnpm install --frozen-lockfile,pnpm build, andpnpm typecheckpass.Written for commit fd3c7d1. Summary will update on new commits.