Repository navigation
Pin h5p-author 0.12.0, and say "no server of ours" - #71
Merged
Merged
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #70.
h5p-author 0.12.0 (missing-elements/h5p-toolkit#230, #218) checks a source's own fields against one schema, so an author written as a bare name is told the object to write. It also checks videos and recordings by their bytes. It brings zod, which the build page and the archive's tool bundle.
What changes
The pin:
package.jsonand the lockfile move@missing-elements/h5p-authorfrom 0.11.0 to 0.12.0. The lockfile also gains zod 4.6.7 and moves@missing-elements/h5p-normalizefrom 1.3.0 to 1.4.0, as 0.12.0 asks.Licence lists: Vite's
build.licensewrites every bundled package with its licence text, in two files:/h5p/assets/build-page-LICENSES.txt, for the build page's scripts: 22 packages, among them zod, zip.js and CodeMirror;/h5p/bundles/h5p-author-LICENSES.txt, forh5p-author.mjs: 6 packages. It also goes intoh5p-author-build.tar.gz, beside the tool.Until now, no notice traveled with zip.js (BSD-3-Clause) or CodeMirror (MIT) either. The build page's footer and the guide's "Free and open source" section link the two lists.
"No server of ours" replaces "no MCP server" in five places:
descriptionandshortDescription(now 62 characters).h5p-offline-player now publishes a local MCP server, so the old phrase is no longer true. The promise behind it still holds.
Size: zod adds 9 kB gzipped to
build-page.js(142 kB → 151 kB).Tested
pnpm install --frozen-lockfile,pnpm buildandpnpm typecheckpass. The lockfile change is only the author, normalize and zod entries; pnpm dropped nolibc:lines this time.plugin.jsonsays 0.12.0, with the new wording.bundles/index.jsonsays author 0.12.0, pack 1.1.0.h5p-author.mjs,h5p-author-LICENSES.txt,libraries.txtandparts/.partsthat h5p-verify passes, ready in 0.18 s."authors": ["Unknown"]withauthors[0]: expected an author: write { "name": "Unknown", "role": "Author" }.vite preview, in Chromium:#source=link with the True/False built and played in 0.6 s: "Built “Water boils at 100 °C”: H5P.TrueFalse, 8 libraries, 882 kB. It plays below."text/plain.Summary by cubic
Pins
@missing-elements/h5p-authorto 0.12.0, which now validates an author's own fields (a bare-name author is told the object to write) and checks videos and recordings by their bytes. It pulls in zod and moves@missing-elements/h5p-normalizeto 1.4.0.build-page-LICENSES.txtandh5p-author-LICENSES.txt, listing every bundled package with its licence text (zod, zip.js, CodeMirror), since MIT and BSD-3-Clause require notices to travel with copies. The two lists are linked from the build page's footer and the guide, and the tool's list travels inside the build archive.build-page.js(142 kB → 151 kB).Written for commit a87c487. Summary will update on new commits.