Skip to content

chore: Remove deprecated code - #1107

Open
stefan-niedermann wants to merge 1 commit into
mainfrom
chore/remove-deprecated-code
Open

stefan-niedermann wants to merge 1 commit into
mainfrom
chore/remove-deprecated-code

Conversation

@stefan-niedermann

Copy link
Copy Markdown
Member

and mark public Constants as deprecated. In a future release, the Constants should be library-scoped to provide a smaller API surface for the SSO library

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI (N/A)

and mark public Constants as deprecated. In a future release, the Constants should be library-scoped to provide a smaller API surface for the SSO library

Signed-off-by: Stefan Niedermann <info@niedermann.it>
@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics -11 complexity

Metric Results
Complexity -11

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@github-actions

Copy link
Copy Markdown

SpotBugs

CategoryBaseNew
Bad practice99
Correctness2324
Dodgy code1314
Internationalization22
Malicious code vulnerability1111
Multithreaded correctness33
Performance44
Security77
Total7274

SpotBugs increased!

@tobiasKaminsky

Copy link
Copy Markdown
Member

Nice, have you tested it, or shall I give it a quick test with Notes?

@github-actions

Copy link
Copy Markdown

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@stefan-niedermann

Copy link
Copy Markdown
Member Author

This PR inteoduces no changes or new features. It only strips old stuff and marks some more as deprecated.
Long term goal is to reduce the API surface to allow refactoring and restructuring internals without affecting 3rd party apps.

I tested with Deck, but additional testing with Notes would be appreciated! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants