Repository navigation
chore(docs): correct defaults and mislabelled externalRedis keys in README - #902
Merged
Merged
Conversation
The parameters table had drifted from values.yaml: - externalRedis.existingSecret.secretName/passwordKey were listed as externalDatabase.existingSecret.*, so the Redis secret keys were undocumented and the database ones appeared twice - nginx.containerPort showed IfNotPresent instead of 80, and the nginx.image.pullPolicy row was duplicated - existingSecret key names, mail/smtp settings, image repositories (library/*, bitnamilegacy/*), redis.auth.password, imaginary.securityContext and the collabora extra_params (--o:ssl.enable) defaults now match values.yaml Bump chart version to 9.4.2. Signed-off-by: sarankumar1325 <120080287+sarankumar1325@users.noreply.github.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
wrenix
approved these changes
Nov 7, 2026
wrenix
enabled auto-merge (squash)
November 7, 2026 07:03
Signed-off-by: sarankumar1325 <120080287+sarankumar1325@users.noreply.github.com>
wrenix
changed the title
Collaborator
|
please rebase and bump version |
Signed-off-by: WrenIX <133280015+wrenix@users.noreply.github.com>
Signed-off-by: WrenIX <133280015+wrenix@users.noreply.github.com>
wrenix
disabled auto-merge
November 12, 2026 21:45
wrenix
enabled auto-merge (squash)
November 12, 2026 21:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
The parameters table in
charts/nextcloud/README.mdno longer matchesvalues.yamlin a few places. This PR changes only the README table, plus the required chart version bump.Wrong or mislabelled keys:
externalRedis.existingSecret.enabledwere namedexternalDatabase.existingSecret.secretName/externalDatabase.existingSecret.passwordKey, but they describe the Redis secret._helpers.tplreads.Values.externalRedis.existingSecret.secretName/.passwordKey, so I renamed them toexternalRedis.existingSecret.*.nginx.containerPortshowedIfNotPresentas its default. The real default is80. Thenginx.image.pullPolicyrow above it was duplicated, so I removed the copy.Stale defaults (the README now shows what
values.yamlsets):image.repository:library/nextcloud.nginx.image.repository:library/nginx.nextcloud.existingSecret.{usernameKey,passwordKey,smtpUsernameKey,smtpPasswordKey,smtpHostKey}:nextcloud-username,nextcloud-password,smtp-username,smtp-password,smtp-host(the README saidnil).externalDatabase.existingSecret.{usernameKey,passwordKey}:db-username,db-password(the README saidnil).nextcloud.mail.*:fromAddressuser,domaindomain.com,smtp.hostdomain.com,smtp.securessl,smtp.port465,smtp.nameuser,smtp.passwordpass.redis.auth.password:changeme.mariadb.image.repository/postgresql.image.repository:bitnamilegacy/mariadb/bitnamilegacy/postgresql.imaginary.securityContext:{runAsUser: 1000, runAsNonRoot: true}.collabora.collabora.extra_params:"--o:ssl.enable=false". The README hadssl.enabled, which is not a Collabora option.Benefits
Users who copy keys from the README now set the values the chart actually reads. This matters most for the external Redis secret, whose documented keys were silently ignored.
Possible drawbacks
None. This is a docs-only change.
Applicable issues
None filed.
Additional information
I found these by comparing every row of the README table against
values.yamland checking the template references.helm lint charts/nextcloudpasses. I used an AI coding assistant to prepare this PR and checked every changed row againstvalues.yamland the templates.Checklist
Chart.yamlaccording to semver.