Repository navigation
Conversation
- Use ShellJS for better GitBash compat than process spawn calls for remaining `update.sh` use - Use the GItHub Action library to pass/set the ENV for the GitHub Action - Add additional logging for local troubleshooting
cbe2c85 to
6fa932c
Compare
6fa932c to
733ea78
Compare
|
Unmarking as draft, as this could land instead of #2650, since it includes those changes |
|
After rebasing in a test branch to drop the last update 80f02a5 and running Committing that change, then rebasing on That's a good test result! |
MikeMcC399
left a comment
There was a problem hiding this comment.
LGTM!
If you're also happy with this, let's take this PR instead of just the preliminary step of #2650
|
Do you want to go ahead with this one? The next Node.js release would be 26.13.0 on Wednesday, Oct 28, 2026, which will be the previous 26.12.1 release, re-tagged with the same content. |
|
@nodejs/docker how about this get's merged tomorrow if no one objects. |
Description
Building on #2650.
The build-automation.mjs now handles all the updating of the Dockerfiles, but drops the previous CLI/options.
This also removes the related special config files and supporting bash scripts.
Motivation and Context
The old
update.shhad a few options around version and variants. While handy for some debugging, with the easiness of comparing the outputs, its better to just test and compare without filtering.Testing Details
npm cinpm run buildNODE_VERSIONshould be pointing to the latestnon-version changes detected, but file not updated.Example Output(if appropriate)
Types of changes
Checklist