Skip to content

fix: handle request errors when fetching CODEOWNERS #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NopeCharon wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: handle request errors when fetching CODEOWNERS #708

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion lib/node-repo.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,8 @@ function getCodeOwnersFile (url, { logger }) {
return new Promise((resolve, reject) => {
https.get(url, (res) => {
if (res.statusCode !== 200) {
// discard the response body so the socket is released
res.resume()
logger.error(`Status code: ${res.statusCode}`, 'Error retrieving OWNERS')
return reject(res.statusCode)
}
Expand All @@ -127,7 +129,11 @@ function getCodeOwnersFile (url, { logger }) {
res.on('end', () => {
return resolve(body)
})
}).on('err', (err) => {
res.on('error', (err) => {
logger.error(err, 'Error retrieving OWNERS')
return reject(err)
})
}).on('error', (err) => {
logger.error(err, 'Error retrieving OWNERS')
return reject(err)
})
Expand Down
22 changes: 22 additions & 0 deletions test/unit/node-repo-owners.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,28 @@ test('getCodeOwnersFile fail', async (t) => {
scope.done()
})

test('getCodeOwnersFile network error', async (t) => {
const options = {
owner: 'nodejs',
repo: 'node-auto-test-6',
prId: 12347,
logger: { info: () => {}, error: () => {}, debug: () => {}, child: function () { return this } },
retries: 1,
defaultBranch: 'main',
retryInterval: 10
}

const base = 'https://localhost'
const filePath = '/CODEOWNERS'
const url = `${base}${filePath}`
const scope = nock(base)
.get(filePath)
.replyWithError('socket hang up')

await t.assert.rejects(getCodeOwnersFile(url, options), { message: 'socket hang up' })
scope.done()
})

test('pingOwners success', async (t) => {
const options = {
owner: 'nodejs',
Expand Down