Repository navigation
fix(docs): header height matches northguild.dev, GitHub link goes to the repo (#350) - #351
Conversation
…the repo (#350) The header was 56px against northguild.dev's and GMT's 55px, so its row sat half a pixel lower and jumped when moving between the sites. --sl-nav-height is now calc(3.375rem + 1px), GMT's value; Starlight's own bottom border is the hairline. The header GitHub icon now goes to github.com/northguild/worktree, named "worktree on GitHub", and the dist audit expects that link.
baldurpan
left a comment
There was a problem hiding this comment.
Read at 8eac77d. The height change matches GMT exactly: apps/dox/src/styles/gmt-theme.css:80 has the same calc(3.375rem + 1px). The new comment's arithmetic also holds against Starlight's border-box header (12px + 30px + 12px padding and row, plus the 1px bottom border, makes 55px). The audit and test updates follow the new href and name.
Two small things, one of them inline:
docs/README.md:275 (not in the diff, so it goes here) still says "src/components/SocialIcons.astro is the GitHub and Discord pair from northguild.dev". After this change GitHub goes to this repository under its own name, so that sentence is no longer true for half the pair. Per AGENTS.md, docs that a change makes untrue are fixed in the same change. Something like "the GitHub and Discord pair from northguild.dev, with GitHub pointed at this repository (#350)" would do. It also protects the refresh path: someone re-copying northguild.dev's hrefs to match the README would put the org link back.
…ays where it goes (#350)
|
Addressed both in 48f6131:
|
baldurpan
left a comment
There was a problem hiding this comment.
Approved at 48f6131. Both points from the first read are fixed: the README sentence now says GitHub points at this repository (projectLink, #350), and the header icon reads projectLink instead of a second copy of the URL. The height matches GMT and adds up to 55px, and CI is green.
Closes #350
Header shift. The worktree header was 56px (
--sl-nav-height: 3.5rem); northguild.dev's and GMT's are 55px, so the whole row sat 0.5px lower and visibly jumped when navigating between them. It is nowcalc(3.375rem + 1px), GMT's value. Worktree keeps Starlight's real 1px bottom border as the hairline, so it does not need GMT's extra 1px bottom padding.Measured with Playwright at 1440px (top/bottom/height, px):
GitHub link. The header icon now goes to https://github.com/northguild/worktree (was the org), named "worktree on GitHub".
audit-distand its tests expect the new link.Checks:
pnpm check, docs tests,pnpm docs:buildandpnpm docs:audit-dist(28 pages) pass locally.Release note: none owed; only
docs/**changes.