Skip to content

fix(docs): header height matches northguild.dev, GitHub link goes to the repo (#350) - #351

Merged
craig-o-curtis merged 2 commits into
mainfrom
350-fix-header-northguilddev-to-worktree-site
Nov 12, 2026
Merged

craig-o-curtis merged 2 commits into
mainfrom
350-fix-header-northguilddev-to-worktree-site

Conversation

@craig-o-curtis

Copy link
Copy Markdown
Contributor

Closes #350

Header shift. The worktree header was 56px (--sl-nav-height: 3.5rem); northguild.dev's and GMT's are 55px, so the whole row sat 0.5px lower and visibly jumped when navigating between them. It is now calc(3.375rem + 1px), GMT's value. Worktree keeps Starlight's real 1px bottom border as the hairline, so it does not need GMT's extra 1px bottom padding.

Measured with Playwright at 1440px (top/bottom/height, px):

header shield + wordmark GitHub / Discord
northguild.dev (live) 0/55/55 13/41/28 8/46/38
/gmt/ (live) 0/55/55 13/41/28 7.98/45.98/38
/worktree/ (live, before) 0/56/56 13.5/41.5/28 8.5/46.5/38
/worktree/, /dox/, /getting-started/ (local, after) 0/55/55 13/41/28 7.98/45.98/38

GitHub link. The header icon now goes to https://github.com/northguild/worktree (was the org), named "worktree on GitHub". audit-dist and its tests expect the new link.

Checks: pnpm check, docs tests, pnpm docs:build and pnpm docs:audit-dist (28 pages) pass locally.

Release note: none owed; only docs/** changes.

…the repo (#350)

The header was 56px against northguild.dev's and GMT's 55px, so its row sat half a pixel lower and jumped when moving between the sites. --sl-nav-height is now calc(3.375rem + 1px), GMT's value; Starlight's own bottom border is the hairline.

The header GitHub icon now goes to github.com/northguild/worktree, named "worktree on GitHub", and the dist audit expects that link.
@craig-o-curtis
craig-o-curtis enabled auto-merge (squash) November 12, 2026 15:29

@baldurpan baldurpan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read at 8eac77d. The height change matches GMT exactly: apps/dox/src/styles/gmt-theme.css:80 has the same calc(3.375rem + 1px). The new comment's arithmetic also holds against Starlight's border-box header (12px + 30px + 12px padding and row, plus the 1px bottom border, makes 55px). The audit and test updates follow the new href and name.

Two small things, one of them inline:

docs/README.md:275 (not in the diff, so it goes here) still says "src/components/SocialIcons.astro is the GitHub and Discord pair from northguild.dev". After this change GitHub goes to this repository under its own name, so that sentence is no longer true for half the pair. Per AGENTS.md, docs that a change makes untrue are fixed in the same change. Something like "the GitHub and Discord pair from northguild.dev, with GitHub pointed at this repository (#350)" would do. It also protects the refresh path: someone re-copying northguild.dev's hrefs to match the README would put the org link back.

Comment thread docs/src/components/SocialIcons.astro Resolved
@craig-o-curtis

Copy link
Copy Markdown
Contributor Author

Addressed both in 48f6131:

  • docs/README.md: the SocialIcons sentence now reads "the GitHub and Discord pair from northguild.dev, with GitHub pointed at this repository (projectLink from src/lib/site-meta.ts, Fix header northguild.dev to worktree site #350)", so a refresh from northguild.dev's hrefs won't put the org link back.
  • SocialIcons.astro: href: projectLink (reply inline).

pnpm check, docs typecheck, pnpm docs:build and pnpm docs:audit-dist (28 pages) pass; the built header links https://github.com/northguild/worktree as "worktree on GitHub (opens in a new tab)".

@baldurpan baldurpan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved at 48f6131. Both points from the first read are fixed: the README sentence now says GitHub points at this repository (projectLink, #350), and the header icon reads projectLink instead of a second copy of the URL. The height matches GMT and adds up to 55px, and CI is green.

@craig-o-curtis
craig-o-curtis merged commit c12e88c into main Nov 12, 2026
1 check passed
@craig-o-curtis
craig-o-curtis deleted the 350-fix-header-northguilddev-to-worktree-site branch November 12, 2026 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix header northguild.dev to worktree site

2 participants