Repository navigation
fix: submit winget manifests with current schema - #52
Merged
Merged
Conversation
This was referenced Oct 30, 2026
This was referenced Oct 30, 2026
rianjs
marked this pull request as ready for review
October 30, 2026 13:38
rianjs
added a commit
to open-cli-collective/atlassian-cli
that referenced
this pull request
Oct 30, 2026
WinGet has deprecated the old manifest schema. Update the checked-in manifest templates to 1.28.0 so future submissions can use the requested schema. Validated the templates against Microsoft’s 1.28.0 JSON schemas with representative checksum values; Windows winget validation remains for CI. Depends on open-cli-collective/.github#52: the pinned shared workflow includes the updated WinGet submission action. Merge that shared PR before this change. The Windows validation workflow installs the checksum-verified WinGet 1.29.380 release and its dependencies to validate schema 1.28.0; actionlint passes. The manual submission workflow uses the shared action pinned to [open-cli-collective/.github#52](open-cli-collective/.github#52), which must be merged before these changes.
rianjs
added a commit
to open-cli-collective/newrelic-cli
that referenced
this pull request
Oct 30, 2026
WinGet has deprecated the old manifest schema. Update the checked-in manifest templates to 1.28.0 so future submissions can use the requested schema. Validated the templates against Microsoft’s 1.28.0 JSON schemas with representative checksum values; Windows winget validation remains for CI. Depends on open-cli-collective/.github#52: the pinned shared workflow includes the updated WinGet submission action. Merge that shared PR before this change. The Windows validation workflow installs the checksum-verified WinGet 1.29.380 release and its dependencies to validate schema 1.28.0; actionlint passes. The manual submission workflow uses the shared action pinned to [open-cli-collective/.github#52](open-cli-collective/.github#52), which must be merged before these changes.
rianjs
added a commit
to open-cli-collective/hubspot-cli
that referenced
this pull request
Oct 30, 2026
WinGet has deprecated the old manifest schema. Update the checked-in templates to 1.28.0 and use the shared submission action so existing package updates also use the current schema. The action resolves release assets and refuses to treat API failures as a missing package. Depends on [open-cli-collective/.github#52](open-cli-collective/.github#52); the workflows pin its commit. Validated the templates against Microsoft’s 1.28.0 JSON schemas with representative checksum values. `actionlint` passed for the changed workflow after suppressing an existing unrelated undefined `inputs.tag` warning in the Snap job. Windows WinGet validation and end-to-end submission remain for CI.
rianjs
added a commit
to open-cli-collective/salesforce-cli
that referenced
this pull request
Oct 30, 2026
WinGet has deprecated the old manifest schema. Update the checked-in templates to 1.28.0 and use the shared submission action so existing package updates also use the current schema. The action resolves release assets and refuses to treat API failures as a missing package. This covers both the release and manual WinGet workflows. The release job uses the supplied tag for manual dispatch. Depends on [open-cli-collective/.github#52](open-cli-collective/.github#52); the workflows pin its commit. Validated the templates against Microsoft’s 1.28.0 JSON schemas with representative checksum values. `actionlint` passed for both workflows. Windows WinGet validation and end-to-end submission remain for CI. The Windows validation workflow installs the checksum-verified WinGet 1.29.380 release and its dependencies to validate schema 1.28.0; actionlint passes.
rianjs
added a commit
to open-cli-collective/spotify-cli
that referenced
this pull request
Oct 30, 2026
WinGet has deprecated the old manifest schema. Update the checked-in manifest templates to 1.28.0 so future submissions can use the requested schema. Validated the templates against Microsoft’s 1.28.0 JSON schemas with representative checksum values; Windows winget validation remains for CI. Depends on open-cli-collective/.github#52: the pinned shared workflow includes the updated WinGet submission action. Merge that shared PR before this change.
rianjs
added a commit
to open-cli-collective/slack-chat-api
that referenced
this pull request
Oct 30, 2026
WinGet has deprecated the old manifest schema. Update the checked-in manifest templates to 1.28.0 so future submissions can use the requested schema. Validated the templates against Microsoft’s 1.28.0 JSON schemas with representative checksum values; Windows winget validation remains for CI. Depends on open-cli-collective/.github#52: the pinned shared workflow includes the updated WinGet submission action. Merge that shared PR before this change. The Windows validation workflow installs the checksum-verified WinGet 1.29.380 release and its dependencies to validate schema 1.28.0; actionlint passes. The manual submission workflow uses the shared action pinned to [open-cli-collective/.github#52](open-cli-collective/.github#52), which must be merged before these changes.
rianjs
added a commit
to open-cli-collective/codereview-cli
that referenced
this pull request
Oct 30, 2026
WinGet has deprecated the old manifest schema. Update the checked-in manifest templates to 1.28.0 so future submissions can use the requested schema. Validated the templates against Microsoft’s 1.28.0 JSON schemas with representative checksum values; Windows winget validation remains for CI. Depends on open-cli-collective/.github#52: the pinned shared workflow includes the updated WinGet submission action. Merge that shared PR before this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The latest published WingetCreate cannot generate the 1.28.0 schema requested by WinGet reviewers. This updates the shared submission action to render existing package updates from the published manifests, render first submissions from the templates, validate them against the official 1.28.0 schemas, and create a PR through the GitHub API without the older serializer. Unexpected installer layouts, unparseable versions and schema downgrades fail closed. Version-specific release notes and dates are cleared on updates.
Validation: 35 unit tests pass, covering preservation of unknown fields, unsupported layouts, fork verification, and schema failures. An update rendered from the live google-readonly upstream manifest preserved all other YAML fields and passed all three official 1.28.0 schemas. A bootstrap from the google-readwrite template also passed all three schemas. The actual GitHub API submission was exercised with a test PR against the personal winget-pkgs fork; its exact file and schema were verified, then the PR was closed and the test branch deleted. All 23 PR checks passed.
The Windows test run validated and installed the separately prepared upstream google-readwrite manifest and invoked its installed grw alias on x64. ARM64 installation was not exercised. Consumers pinned to a shared-workflow commit must repin after this is merged; moving any floating release tag is a separate rollout.