Repository navigation
fix(chat): accept reasoning alias in completion messages - #834
Merged
iBotPeaches merged 1 commit intoNov 9, 2026
Merged
Conversation
iBotPeaches
approved these changes
Nov 9, 2026
Collaborator
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Non-streamed chat completions lose reasoning when an OpenAI-compatible server returns
message.reasoning, as vLLM'sChatMessagedoes (the server #751 added streaming support for):CreateResponseMessage::from()only readsreasoning_content, soreasoningContentisnull.What:
Description:
Accept
reasoningas a fallback forreasoning_content, extending the alias support from #824 to non-streamed messages. The existingreasoning_contentfield keeps precedence, including empty strings, andtoArray()continues to emitreasoning_content.Five regression cases cover the alias, precedence, null fallback, empty content and absent reasoning. Before the fix, two cases fail; after it, all five pass. The full Pest suite passes (1428 passed, 34 deprecation notices); PHPStan passes and Pint formats both changed files.
Related:
Related to #780 and #824. This addresses the non-streamed counterpart; the original streaming issue is already closed.
This change was prepared with an AI coding assistant (Codex).