[jseop-lim]

Fixes #1231

checkFlags called raiseStatic(this, ValueError, null, NO_VALUE, ErrorMessages.UNRECOGNIZED_FLAGS, PythonUtils.EMPTY_OBJECT_ARRAY), which binds to the (Node, type, TruffleString message, Object...) overload, so the exception had a null message format. Catching it worked, but reading its message threw a Java NullPointerException.

AS-IS

>>> try:
...     compile('1', 'f', 'exec', 0x7fffffff)
... except ValueError as e:
...     print(e)
...
java.lang.NullPointerException: Cannot invoke "com.oracle.truffle.api.strings.TruffleString.toJavaStringUncached()" because "format" is null

TO-BE

compile(): unrecognised flags

(matching CPython)

Changes

• Raise with raiseStatic(this, ValueError, ErrorMessages.UNRECOGNIZED_FLAGS), as checkOptimize next to it does.
• Add test_compile_unrecognised_flags_message to tests/test_parser.py.

Testing

mx python-jvm on linux-aarch64, then mx graalpytest test_parser.py test_exec.py test_ast.py test_code.py (108 passed). test.test_compile and test.test_builtin from lib-python report the same failures and errors as on master. The new test crashes on the unpatched build. A str, a bytes and a None source with bad flags now print the same message and args as CPython 3.12.13.