Repository navigation
Keep south-up raster windows in native row order - #324
Draft
Sinkleberg wants to merge 1 commit into
Draft
Sinkleberg wants to merge 1 commit into
Sinkleberg wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Positive-y rasters could produce a negative window height or place a cropped array at the wrong coordinates. This builds on Matthew Perry’s
southupprototype for #98 and keeps the raster’s original row order, including for point interpolation.I tested NumPy arrays and GeoTIFFs. All 136 tests pass with Affine 2.4. With #323 applied, all 137 pass on both Affine 2.4 and 3.0.1. I’ve left this as a draft while #323 is open because the existing coordinate operators raise deprecation warnings on 3.0.1.
Refs #98. This covers axis-aligned rasters. Prepared with Codex.