Repository navigation
Clean up client package - #3
Merged
Merged
Conversation
- Fail fast with a SkirClientException when no base URL is configured. - Print a short summary when generation fails instead of repeating the streamed compiler output. - Require illuminate/console (used) instead of illuminate/contracts (unused) and support Laravel 12 and 13 only; 10 and 11 are end-of-life. - Keep tests, docs and CI files out of dist archives. - Docs: requirements, protocol and server pointers in the README, correct redirect behaviour, and tighter wording.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-ups from a code review. Stacked on #2.
SkirClientwithoutSKIR_CLIENT_BASE_URLthrowsSkirClientException::missingBaseUrl(). Before, it failed at call time with aFatalRequestExceptionthat looked like a DNS error.skir:generate-clientprints a one-line failure summary instead of repeating stderr it already streamed.composer.json: requireilluminate/console(used) instead ofilluminate/contracts(unused). Support Laravel 12 and 13 only (10 and 11 are EOL), with matching testbench and phpunit ranges and CI matrix..gitattributeskeeps tests, docs, art and CI files out of dist archives.resources/booststill ships.configure-composernote. Tighter wording.