Skip to content

Clean up client package - #3

Merged
happyDemon merged 1 commit into
skir-rpc-protocolfrom
cleanup
Nov 9, 2026
Merged

happyDemon merged 1 commit into
skir-rpc-protocolfrom
cleanup

Conversation

@happyDemon

Copy link
Copy Markdown
Member

Follow-ups from a code review. Stacked on #2.

  • Resolving SkirClient without SKIR_CLIENT_BASE_URL throws SkirClientException::missingBaseUrl(). Before, it failed at call time with a FatalRequestException that looked like a DNS error.
  • skir:generate-client prints a one-line failure summary instead of repeating stderr it already streamed.
  • composer.json: require illuminate/console (used) instead of illuminate/contracts (unused). Support Laravel 12 and 13 only (10 and 11 are EOL), with matching testbench and phpunit ranges and CI matrix.
  • .gitattributes keeps tests, docs, art and CI files out of dist archives. resources/boost still ships.
  • Docs: README requirements and protocol/server pointers. Corrected redirect behaviour (Guzzle follows redirects). Removed an authoring note that leaked into Boost guidance. Generator-agnostic configure-composer note. Tighter wording.

- Fail fast with a SkirClientException when no base URL is configured.
- Print a short summary when generation fails instead of repeating the
  streamed compiler output.
- Require illuminate/console (used) instead of illuminate/contracts (unused)
  and support Laravel 12 and 13 only; 10 and 11 are end-of-life.
- Keep tests, docs and CI files out of dist archives.
- Docs: requirements, protocol and server pointers in the README, correct
  redirect behaviour, and tighter wording.
@happyDemon
happyDemon merged commit 2cf049c into skir-rpc-protocol Nov 9, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant