Repository navigation
Drop CBOR support - #1
Merged
Merged
Conversation
CBOR only re-encoded the dense JSON value tree, so it saved little once HTTP compression is applied and kept bytes fields base64 encoded. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
Cborhelper, its CBOR-specific exception factories, and the optionalspomky-labs/cbor-phpdependency.CBOR only re-encoded the dense JSON value tree. Dense JSON already drops field names, so the remaining savings were JSON punctuation: 30-50% uncompressed, but only 3-10% after gzip/brotli, and none for
bytesfields (still base64 strings inside the tree).This is a breaking change: release as
0.2.0(branch alias bumped to0.2.x-dev).serverandclient0.1.x stay on runtime 0.1.x.Companion PRs: php-skir/client and php-skir/server
drop-cbor.