Repository navigation
Drop CBOR support - #1
Merged
Merged
Conversation
CBOR only re-encoded the dense JSON value tree, so it saved little once HTTP compression is applied and kept bytes fields base64 encoded. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Pull request checkouts are detached merge commits, so the path repository reports dev-<sha> instead of dev-main. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
CborCodec,SkirCodecs::cbor(),SkirServerException::missingCborDependency(), and the CBOR-onlySkirHttpCodecinterface. The controller now always reads a JSON envelope (or the query string) and returns JSON.Docs, Boost guidelines/skill and tests updated accordingly.
Breaking: release as
0.2.0. Sibling constraints are^0.1@dev|^0.2@devso CI stays green regardless of merge order.Warning
CBOR mode in
@php-skir/skir-clientwas the only way a TypeScript client could call this server. The upstream Skir TS client POSTsMethod:number:format:json(colon-separated), which this server does not parse. Until the server accepts the upstream request format, TypeScript consumers have no working transport after this lands.