Skip to content

Drop CBOR support - #1

Merged
happyDemon merged 2 commits into
mainfrom
drop-cbor
Nov 9, 2026
Merged

happyDemon merged 2 commits into
mainfrom
drop-cbor

Conversation

@happyDemon

@happyDemon happyDemon commented Nov 9, 2026 •

Copy link
Copy Markdown
Member

Removes CborCodec, SkirCodecs::cbor(), SkirServerException::missingCborDependency(), and the CBOR-only SkirHttpCodec interface. The controller now always reads a JSON envelope (or the query string) and returns JSON.

Docs, Boost guidelines/skill and tests updated accordingly.

Breaking: release as 0.2.0. Sibling constraints are ^0.1@dev|^0.2@dev so CI stays green regardless of merge order.

Warning

CBOR mode in @php-skir/skir-client was the only way a TypeScript client could call this server. The upstream Skir TS client POSTs Method:number:format:json (colon-separated), which this server does not parse. Until the server accepts the upstream request format, TypeScript consumers have no working transport after this lands.

happyDemon and others added 2 commits November 9, 2026 11:03
CBOR only re-encoded the dense JSON value tree, so it saved little once
HTTP compression is applied and kept bytes fields base64 encoded.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Pull request checkouts are detached merge commits, so the path repository
reports dev-<sha> instead of dev-main.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@happyDemon
happyDemon merged commit c16163a into main Nov 9, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant